Issue 13335048: Fix go relations in sandbox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13335048: Fix go relations in sandbox

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by matthew.scott

Modified:
10 years, 7 months ago

Reviewers:
rharding, jeff.pihach, mp+183508

Visibility:
Public.

Description

Fix go relations in sandbox Go relations now working in sandbox. This finally actually really totally checks in changing the environment type, as well. https://code.launchpad.net/~makyo/juju-gui/go-relations/+merge/183508 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix go relations in sandbox #

Patch Set 3 : Fix go relations in sandbox #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -13 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/config-debug.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/config-prod.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/store/env/base.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/fakebackend.js	View	1 2	2 chunks	+15 lines, -6 lines	0 comments	Download
M	app/store/env/sandbox.js	View	1	4 chunks	+22 lines, -5 lines	0 comments	Download
M	test/test_fakebackend.js	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	test/test_sandbox_go.js	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rharding

LGTM with comment https://codereview.appspot.com/13335048/diff/1/app/store/env/fakebackend.js File app/store/env/fakebackend.js (right): https://codereview.appspot.com/13335048/diff/1/app/store/env/fakebackend.js#newcode700 app/store/env/fakebackend.js:700: and endpoint connection type ie) wordpress:db. ...

10 years, 7 months ago (2013-09-02 16:58:45 UTC) #2

jeff.pihach

QA Failed When creating relations using both techniques the relation line appears then disappears after ...

10 years, 7 months ago (2013-09-02 22:52:33 UTC) #3

matthew.scott

10 years, 7 months ago (2013-09-03 10:07:19 UTC) #6

*** Submitted:

Fix go relations in sandbox

Go relations now working in sandbox.  This finally actually really totally
checks in changing the environment type, as well.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/13335048

Expand All Messages | Collapse All Messages