Issue 13334050: code review 13334050: go.tools/oracle: set AllASTs=true always, and simplify.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13334050: code review 13334050: go.tools/oracle: set AllASTs=true always, and simplify. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by adonovan

Modified:
10 years, 7 months ago

Reviewers:
Dominik Honnef, crawshaw1

CC:
crawshaw1, Dominik Honnef, golang-dev

Visibility:
Public.

Description

go.tools/oracle: set AllASTs=true always, and simplify. Every one of the oracle's query modes needs to have typed ASTs available, at least transiently, so that the -pos flag can be interpreted. (The only mode that doesn't need the -pos flag is callgraph, but that needs PTA.) So we hard-code it to true. This change fixes a bug in the 'implements' query that causes -pos parsing to fail. (This wasn't exposed by the tests because they are degenerate in that the query always occurs in the main package, which is specified ad-hoc, i.e. as a source file not an import path. That's unfortunate, but this change renders the distinction uninteresting in future.)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -12 lines)			Patch
	M	oracle/oracle.go	View	1	3 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 7 months ago (2013-09-11 14:02:46 UTC) #1

adonovan

10 years, 7 months ago (2013-09-12 14:55:26 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=3d3b3db2eb1e&repo=tools ***

go.tools/oracle: set AllASTs=true always, and simplify.

Every one of the oracle's query modes needs to have typed ASTs
available, at least transiently, so that the -pos flag can be
interpreted.  (The only mode that doesn't need the -pos flag
is callgraph, but that needs PTA.)  So we hard-code it to true.

This change fixes a bug in the 'implements' query that causes
-pos parsing to fail.  (This wasn't exposed by the tests
because they are degenerate in that the query always occurs in
the main package, which is specified ad-hoc, i.e. as a source
file not an import path.  That's unfortunate, but this
change renders the distinction uninteresting in future.)

R=crawshaw, dominik.honnef
CC=golang-dev
https://codereview.appspot.com/13334050

Expand All Messages | Collapse All Messages