Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1571)

Issue 13334046: Zoom to center on dimensions set

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by matthew.scott
Modified:
10 years, 7 months ago
Reviewers:
rharding, mp+183606
Visibility:
Public.

Description

Zoom to center on dimensions set The dimensions of the canvas default to 800x600px, and so on smaller screens, centering the services in the environment centered them beneath the charm store. This centers them *after* the sizes are calculated, which centers them in the center of the screen itself. https://code.launchpad.net/~makyo/juju-gui/center-on-load/+merge/183606 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Zoom to center on dimensions set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/viewport.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_service_module.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_viewport_module.js View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
10 years, 7 months ago (2013-09-03 09:45:47 UTC) #1
rharding
LGTM QA's ok in chrome, need IE QA.
10 years, 7 months ago (2013-09-03 10:43:48 UTC) #2
matthew.scott
Okay in IE10
10 years, 7 months ago (2013-09-03 13:27:18 UTC) #3
matthew.scott
10 years, 7 months ago (2013-09-03 13:32:22 UTC) #4
*** Submitted:

Zoom to center on dimensions set

The dimensions of the canvas default to 800x600px, and so on smaller screens,
centering the services in the environment centered them beneath the charm store.
 This centers them *after* the sizes are calculated, which centers them in the
center of the screen itself.

R=rharding
CC=
https://codereview.appspot.com/13334046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b