Issue 13334045: Add version to the cert API, and a test for V1 certs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13334045: Add version to the cert API, and a test for V1 certs

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by ekasper

Modified:
10 years, 8 months ago

Reviewers:
Eran

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Add version to the cert API, and a test for V1 certs

Patch Set 2 : check basicconstraints #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
M	src/python/ct/crypto/cert.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/python/ct/crypto/cert_test.py	View	1	4 chunks	+20 lines, -8 lines	0 comments	Download
A +	src/python/ct/crypto/testdata/v1_cert.pem	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Eran

LGTM, see suggestion for additional check. https://codereview.appspot.com/13334045/diff/1/src/python/ct/crypto/cert_test.py File src/python/ct/crypto/cert_test.py (right): https://codereview.appspot.com/13334045/diff/1/src/python/ct/crypto/cert_test.py#newcode147 src/python/ct/crypto/cert_test.py:147: self.assertEqual(0, c.version()) Also ...

10 years, 8 months ago (2013-08-30 13:36:47 UTC) #2

ekasper

10 years, 8 months ago (2013-08-30 14:21:32 UTC) #3

https://codereview.appspot.com/13334045/diff/1/src/python/ct/crypto/cert_test.py
File src/python/ct/crypto/cert_test.py (right):

https://codereview.appspot.com/13334045/diff/1/src/python/ct/crypto/cert_test...
src/python/ct/crypto/cert_test.py:147: self.assertEqual(0, c.version())
On 2013/08/30 13:36:47, Eran wrote:
> Also check that calling get_extensions does not throw

There's no get_extensions yet because I haven't decided on that API, but I've
added a check for basicConstraints.

Expand All Messages | Collapse All Messages