code review 13330044: misc/pprof: work with either LWP::UserAgent or curl

misc/pprof: work with either LWP::UserAgent or curl

Use either LWP::UserAgent or curl to make HTTP requests so it
works on Windows (most Perl distros include LWP::UserAgent),
and also on OS X (whose Perl at least sometimes doesn't
include LWP::UserAgent).

Fixes issue 6273

[bradfitz, 2013-08-29 00:13:40]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2013-08-29 01:59:16]

It still works for me here on windows.

Alex

[bradfitz, 2013-08-29 16:00:18]

Alex, is that a LGTM?  Nobody else will want to give one for perl.



On Wed, Aug 28, 2013 at 6:59 PM, <alex.brainman@gmail.com> wrote:

> It still works for me here on windows.
>
> Alex
>
>
https://codereview.appspot.**com/13330044/<https://codereview.appspot.com/133...
>

[Charlie Dorian, 2013-08-29 22:35:02]

Please excuse my unfamiliarity, but If I want to try it out, do I type "hg 
clpatch 13330044", to download the code, and then test it?

-- Charlie

On Thursday, August 29, 2013 12:00:16 PM UTC-4, Brad Fitzpatrick wrote:
>
> Alex, is that a LGTM?  Nobody else will want to give one for perl.
>
>
>
> On Wed, Aug 28, 2013 at 6:59 PM, <alex.b...@gmail.com <javascript:>>wrote:
>
>> It still works for me here on windows.
>>
>> Alex
>>
>>
https://codereview.appspot.**com/13330044/<https://codereview.appspot.com/133...
>>
>
>

[bradfitz, 2013-08-29 22:39:00]

Yes.

But you'll need to run make.bash (or make.bat) to copy it to where "go tool
pprof" expects to find it.



On Thu, Aug 29, 2013 at 3:35 PM, Charlie Dorian <cldorian@gmail.com> wrote:

> Please excuse my unfamiliarity, but If I want to try it out, do I type "hg
> clpatch 13330044", to download the code, and then test it?
>
> -- Charlie
>
>
> On Thursday, August 29, 2013 12:00:16 PM UTC-4, Brad Fitzpatrick wrote:
>
>> Alex, is that a LGTM?  Nobody else will want to give one for perl.
>>
>>
>>
>> On Wed, Aug 28, 2013 at 6:59 PM, <alex.b...@gmail.com> wrote:
>>
>>> It still works for me here on windows.
>>>
>>> Alex
>>>
>>>
https://codereview.appspot.**com**/13330044/<https://codereview.appspot.com/1...
>>>
>>
>>

[brainman, 2013-08-29 23:30:30]

LGTM

(I trust you :-)

Alex

[brainman, 2013-08-29 23:31:44]

On 2013/08/29 22:39:00, bradfitz wrote:
> 
> But you'll need to run make.bash ...

Alternatively you can run rsc's make:

go tool dist install misc/pprof

Alex

[bradfitz, 2013-08-29 23:42:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=bd825a13f08b ***

misc/pprof: work with either LWP::UserAgent or curl

Use either LWP::UserAgent or curl to make HTTP requests so it
works on Windows (most Perl distros include LWP::UserAgent),
and also on OS X (whose Perl at least sometimes doesn't
include LWP::UserAgent).

Fixes issue 6273

R=golang-dev, alex.brainman, cldorian
CC=golang-dev
https://codereview.appspot.com/13330044