code review 133290043: text/template/parse: restore pointer-only receivers for...

text/template/parse: restore pointer-only receivers for Type on Dot and Nil
Needless except that the api tool complains. We could fix that issue instead.

[r, 2014-08-29 17:40:08]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2014-08-29 17:40:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=173175ba9eb7 ***

text/template/parse: restore pointer-only receivers for Type on Dot and Nil
Needless except that the api tool complains. We could fix that issue instead.

TBR=bradfitz
R=golang-codereviews
CC=golang-codereviews
https://codereview.appspot.com/133290043

[bradfitz, 2014-08-29 17:40:56]

LGTM




On Fri, Aug 29, 2014 at 10:40 AM, <r@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> text/template/parse: restore pointer-only receivers for Type on Dot and
> Nil
> Needless except that the api tool complains. We could fix that issue
> instead.
>
> Please review this at https://codereview.appspot.com/133290043/
>
> Affected files (+14, -0 lines):
>   M src/pkg/text/template/parse/node.go
>
>
> Index: src/pkg/text/template/parse/node.go
> ===================================================================
> --- a/src/pkg/text/template/parse/node.go
> +++ b/src/pkg/text/template/parse/node.go
> @@ -360,6 +360,13 @@
>         return &DotNode{tr: t, NodeType: NodeDot, Pos: pos}
>  }
>
> +func (d *DotNode) Type() NodeType {
> +       // Override method on embedded NodeType for API compatibility.
> +       // TODO: Not really a problem; could change API without effect but
> +       // api tool complains.
> +       return NodeDot
> +}
> +
>  func (d *DotNode) String() string {
>         return "."
>  }
> @@ -383,6 +390,13 @@
>         return &NilNode{tr: t, NodeType: NodeNil, Pos: pos}
>  }
>
> +func (n *NilNode) Type() NodeType {
> +       // Override method on embedded NodeType for API compatibility.
> +       // TODO: Not really a problem; could change API without effect but
> +       // api tool complains.
> +       return NodeNil
> +}
> +
>  func (n *NilNode) String() string {
>         return "nil"
>  }
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>