Issue 133260044: code review 133260044: runtime: fix sprintf index out of bounds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 133260044: code review 133260044: runtime: fix sprintf index out of bounds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
gobot, 0intro

CC:
r, golang-codereviews

Visibility:
Public.

Description

runtime: fix sprintf index out of bounds Breaks on Plan 9, apparently. The other systems must not run sprintf during all.bash. I'd write a test but it's all going away.

Patch Set 1 #

Patch Set 2 : diff -r 2223117574c2cba577bfc8ecf822ce133fc2821a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2223117574c2cba577bfc8ecf822ce133fc2821a https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/print1.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: 0intro, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2014-08-29 14:28:56 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=e70df1c4b76f *** runtime: fix sprintf index out of bounds Breaks on Plan ...

11 years, 3 months ago (2014-08-29 14:29:05 UTC) #2

0intro

LGTM Thanks. We're lucky enough Plan 9 uses error strings, so we have been able ...

11 years, 3 months ago (2014-08-29 14:48:46 UTC) #3

gobot

11 years, 3 months ago (2014-08-29 15:35:08 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/d36338618474bdfa87b9777b24e6ecb4be32d56a

Expand All Messages | Collapse All Messages