Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6018)

Issue 13321052: environs/storage, state/statecmd: reenable tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
gz, mp+187018
Visibility:
Public.

Description

environs/storage, state/statecmd: reenable tests Also add a script to .lbox.check to make sure this doesn't happen again. https://code.launchpad.net/~rogpeppe/juju-core/415-environs-storage-enable-tests/+merge/187018 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/storage, state/statecmd: reenable tests #

Patch Set 3 : environs/storage, state/statecmd: reenable tests #

Patch Set 4 : environs/storage, state/statecmd: reenable tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
.lbox.check View 1 chunk +3 lines, -0 lines 0 comments Download
[revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
environs/storage/storage_test.go View 2 chunks +5 lines, -0 lines 0 comments Download
environs/testing/polling_test.go View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
scripts/checktesting.bash View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
state/statecmd/package_test.go View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
10 years, 7 months ago (2013-09-23 13:21:53 UTC) #1
gz
LGTM, a comment or two in the script may not hurt.
10 years, 7 months ago (2013-09-23 13:28:45 UTC) #2
rog
Please take a look.
10 years, 7 months ago (2013-09-23 13:37:19 UTC) #3
rog
10 years, 7 months ago (2013-09-23 13:38:20 UTC) #4
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b