Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1107)

Issue 13314048: code review 13314048: cmd/ld: fix "_image_base__ not defined" problem for cmd/8l. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by minux1
Modified:
9 years, 2 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/ld: fix "_image_base__ not defined" problem for cmd/8l. Fixes issue 6431. Change suggested by kin.wilson.za.

Patch Set 1 #

Patch Set 2 : diff -r 00ff0c821b3f https://code.google.com/p/go #

Patch Set 3 : diff -r 00ff0c821b3f https://code.google.com/p/go #

Patch Set 4 : diff -r b9d8e297919c https://code.google.com/p/go #

Patch Set 5 : diff -r 06c20cdf7bc0 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/cmd/ld/pe.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 2 months ago (2013-09-23 04:14:28 UTC) #1
rsc
LGTM
9 years, 2 months ago (2013-09-23 13:40:23 UTC) #2
minux1
9 years, 2 months ago (2013-09-23 17:08:09 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=46b68d2aa38e ***

cmd/ld: fix "_image_base__ not defined" problem for cmd/8l.
Fixes issue 6431.

Change suggested by kin.wilson.za.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13314048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b