Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(288)

Issue 133140043: code review 133140043: runtime: rename Lock to Mutex (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rsc
Modified:
10 years, 8 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant, dvyukov, r
Visibility:
Public.

Description

runtime: rename Lock to Mutex Mutex is consistent with package sync, and when in the unexported Go form it avoids having a conflcit between the type (now mutex) and the function (lock).

Patch Set 1 #

Patch Set 2 : diff -r dbef39a08d10201cf67b38c16d223fdbc54ab385 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 57dfd03985a9bf6c845114140e043b53f2fd45a9 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 50f9b7e05ec341d4a0d33068c9fa5efcd42ea94c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -106 lines) Patch
M src/pkg/runtime/atomic_arm.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgocall.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/chan.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/chan.go View 1 6 chunks +9 lines, -9 lines 0 comments Download
M src/pkg/runtime/cpuprof.goc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/export_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/iface.go View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/runtime/iface.goc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/lock_futex.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/lock_sema.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/malloc.h View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/runtime/malloc.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/malloc.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/mem_plan9.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mgc0.c View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/mprof.go View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/runtime/mprof.goc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/netpoll.goc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/os_windows.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/panic.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/print.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/proc.c View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/runtime/proc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M src/pkg/runtime/runtime.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sema.go View 1 8 chunks +11 lines, -11 lines 0 comments Download
M src/pkg/runtime/stack.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/stubs.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/runtime/stubs.goc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/pkg/runtime/syscall_windows.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/time.go View 1 8 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, r), I'd like you to review this change to https://code.google.com/p/go/
10 years, 8 months ago (2014-08-28 02:54:26 UTC) #1
iant
LGTM https://codereview.appspot.com/133140043/diff/40001/src/pkg/runtime/cgocall.c File src/pkg/runtime/cgocall.c (right): https://codereview.appspot.com/133140043/diff/40001/src/pkg/runtime/cgocall.c#newcode118 src/pkg/runtime/cgocall.c:118: * Mutex g to m to ensure we ...
10 years, 8 months ago (2014-08-28 03:06:48 UTC) #2
rsc
I swear I fixed those. I'll double-check, but I think I just forgot to reupload.
10 years, 8 months ago (2014-08-28 03:17:10 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=5b870283b7ae *** runtime: rename Lock to Mutex Mutex is consistent with package ...
10 years, 8 months ago (2014-08-28 03:32:54 UTC) #4
gobot
10 years, 8 months ago (2014-08-28 03:35:05 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/e338f2c0a146ac73ee72cfb05ad4797f1d278fae
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b