Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1211)

Issue 13313044: GUI server deployer: update the Import request.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
mp+183904, matthew.scott
Visibility:
Public.

Description

GUI server deployer: update the Import request. Updated the Import deployer request so that the Name field is optional if the YAML one contains just one bundle. https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-optional-bundle-name/+merge/183904 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : GUI server deployer: update the Import request. #

Patch Set 3 : GUI server deployer: update the Import request. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/bundles/__init__.py View 1 chunk +4 lines, -2 lines 0 comments Download
M server/guiserver/bundles/views.py View 1 chunk +7 lines, -2 lines 0 comments Download
M server/guiserver/tests/bundles/test_views.py View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3
frankban
Please take a look.
10 years, 6 months ago (2013-09-04 15:25:35 UTC) #1
matthew.scott
code LGTM
10 years, 6 months ago (2013-09-04 15:28:04 UTC) #2
frankban
10 years, 6 months ago (2013-09-04 15:41:28 UTC) #3
*** Submitted:

GUI server deployer: update the Import request.

Updated the Import deployer request so that the Name
field is optional if the YAML one contains just one bundle.

R=matthew.scott
CC=
https://codereview.appspot.com/13313044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b