Issue 13309044: The GUI no longer run from the charm directory.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13309044: The GUI no longer run from the charm directory.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by frankban

Modified:
10 years, 7 months ago

Reviewers:
benjamin.saller, mp+183589

Visibility:
Public.

Description

The GUI no longer run from the charm directory. Updated the GUI and (under pyJuju) the API agent so that now the files are served from /var/lib/juju-gui. That directory is also removed when the service is destroyed. To do that, this branch introduces the Backend.destroy method, called in the stop hook. QA: deploy the charm using this branch, check everything is ok, check that the GUI files are stored in /var/lib/juju-gui. Then destroy the juju-gui service and ensure that directory is cleaned up. https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1218042-charm-directory/+merge/183589 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : The GUI no longer run from the charm directory. #

Patch Set 3 : The GUI no longer run from the charm directory. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -49 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/backend.py	View		7 chunks	+24 lines, -12 lines	0 comments	Download
M	hooks/config-changed	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	hooks/stop	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	hooks/utils.py	View	1 2	6 chunks	+16 lines, -15 lines	0 comments	Download
M	revision	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_backends.py	View		8 chunks	+52 lines, -14 lines	0 comments	Download
M	tests/test_utils.py	View	1 2	3 chunks	+27 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM, thanks https://codereview.appspot.com/13309044/diff/1/hooks/backend.py File hooks/backend.py (right): https://codereview.appspot.com/13309044/diff/1/hooks/backend.py#newcode302 hooks/backend.py:302: destroy = chain_methods('destroy', reverse=True) I think this ...

10 years, 7 months ago (2013-09-03 10:23:09 UTC) #2

frankban

*** Submitted: The GUI no longer run from the charm directory. Updated the GUI and ...

10 years, 7 months ago (2013-09-03 14:22:12 UTC) #3

Thanks for the review Ben!

Expand All Messages | Collapse All Messages