Issue 13289049: Fixes ac closing and related tab on inspector.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13289049: Fixes ac closing and related tab on inspector.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rharding

Modified:
10 years, 8 months ago

Reviewers:
mp+184256, benjamin.saller

Visibility:
Public.

Description

Fixes ac closing and related tab on inspector. - Fixes: 1220708 make sure to close the AC on submit - Partially addresses: 1220254 removes the related charms tab from the inspector view of the charm details. https://code.launchpad.net/~rharding/juju-gui/fix-ac-close/+merge/184256 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes ac closing and related tab on inspector. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	app/widgets/charm-search.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/test_browser_charm_details.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/test_browser_search_widget.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM thanks https://codereview.appspot.com/13289049/diff/1/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (left): https://codereview.appspot.com/13289049/diff/1/app/subapps/browser/templates/browser_charm.handlebars#oldcode160 app/subapps/browser/templates/browser_charm.handlebars:160: Interfaces determine how this charm relates to ...

10 years, 8 months ago (2013-09-06 09:12:25 UTC) #2

rharding

10 years, 8 months ago (2013-09-06 09:19:32 UTC) #3

*** Submitted:

Fixes ac closing and related tab on inspector.

- Fixes: 1220708 make sure to close the AC on submit
- Partially addresses: 1220254 removes the related charms tab from the
inspector view of the charm details.

R=benjamin.saller
CC=
https://codereview.appspot.com/13289049

Expand All Messages | Collapse All Messages