Removes filters from search

Removes filters from search

-Removes filter widget from search views
-Removes show/hide logic
-Removes defaults from filter model
-Adds search organization search view
-Tests

https://code.launchpad.net/~jcsackett/juju-gui/no-default-search-filters/+merge/183172

(do not edit description out of merge proposal)

[j.c.sackett, 2013-08-30 13:52:48]

Please take a look.

[rharding, 2013-08-30 14:35:35]

LGTM with the note below on cleaning up.

https://codereview.appspot.com/13289046/diff/1/app/subapps/browser/views/sear...
File app/subapps/browser/views/search.js (right):

https://codereview.appspot.com/13289046/diff/1/app/subapps/browser/views/sear...
app/subapps/browser/views/search.js:84:
bestContainer.render(results_container.one('.best'));
these new containers need to be destroyed on the view's destroy

[j.c.sackett, 2013-08-30 17:48:08]

Please take a look.

[rharding, 2013-08-30 20:07:49]

qa not ok. 

- 10 is too many for the sidebar. There's no ability to know there's another
category below. This should default a lot lower.

- Fullscreen fails for me. The api calls go out, but it doesn't display
anything. 

- Because of the fullscreen issue, getting results in sidebar and viewmode
switching to fullscreen fails. 

Stopped qa'ing here.

[j.c.sackett, 2013-08-30 21:24:41]

Please take a look.

[j.c.sackett, 2013-08-30 21:55:09]

On 2013/08/30 20:07:49, rharding wrote:
> - 10 is too many for the sidebar. There's no ability to know there's another
> category below. This should default a lot lower.

I've tried 5.
 
> - Fullscreen fails for me. The api calls go out, but it doesn't display
> anything. 
> 
> - Because of the fullscreen issue, getting results in sidebar and viewmode
> switching to fullscreen fails. 

This appears to be fixed now.

[rharding, 2013-09-01 00:11:02]

Thanks for the update. Fullscreen does work now, but there's an issue with the
following

- open the browser in build mode
- click on the search box, select a category (app servers)
- Once results load, switch to browser mode 

No results. This does work on coming soon.

[rharding, 2013-09-02 13:01:59]

There's also an issue with fullscreen-charm details.

- Go to fullscreen
- search for apache
- click on a result
- The details opens in sidebar mode vs fullscreen

[j.c.sackett, 2013-09-03 14:37:55]

> - open the browser in build mode
> - click on the search box, select a category (app servers)
> - Once results load, switch to browser mode 
> 
> No results. This does work on coming soon.

I have replicated this, and will fix it.

> There's also an issue with fullscreen-charm details.
> 
> - Go to fullscreen
> - search for apache
> - click on a result
> - The details opens in sidebar mode vs fullscreen

I can replicate this in trunk, it's not related to my changes.

[j.c.sackett, 2013-09-05 20:45:39]

Please take a look.

[rharding, 2013-09-06 08:25:33]

LGTM code with the two comments.

Will QA in a sec.

https://codereview.appspot.com/13289046/diff/19001/app/subapps/browser/browse...
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/13289046/diff/19001/app/subapps/browser/browse...
app/subapps/browser/browser.js:634: extraCfg.envSeries = this.get('envSeries');
should we just stick this in the _getViewCfg and always provide it to all views?

https://codereview.appspot.com/13289046/diff/19001/app/subapps/browser/views/...
File app/subapps/browser/views/search.js (right):

https://codereview.appspot.com/13289046/diff/19001/app/subapps/browser/views/...
app/subapps/browser/views/search.js:168: series = 'precise';
can this if check and hard coded value go away then?

[rharding, 2013-09-06 08:39:04]

QA ok.

[j.c.sackett, 2013-09-06 13:16:43]

>
https://codereview.appspot.com/13289046/diff/19001/app/subapps/browser/browse...
> app/subapps/browser/browser.js:634: extraCfg.envSeries =
this.get('envSeries');
> should we just stick this in the _getViewCfg and always provide it to all
views?

Yes, I will make that change.

>
https://codereview.appspot.com/13289046/diff/19001/app/subapps/browser/views/...
> app/subapps/browser/views/search.js:168: series = 'precise';
> can this if check and hard coded value go away then?

Nope; env isn't guaranteed to have default series, e.g. on sandbox.

[j.c.sackett, 2013-09-06 16:31:43]

*** Submitted:

Removes filters from search

-Removes filter widget from search views
-Removes show/hide logic
-Removes defaults from filter model
-Adds search organization search view
-Tests

R=rharding
CC=
https://codereview.appspot.com/13289046