Switch the default environment to Go.

Switch the default environment to Go.

Fixed and cleaned up all the failing tests.

https://code.launchpad.net/~frankban/juju-gui/switch-default-env/+merge/182440

(do not edit description out of merge proposal)

[frankban, 2013-08-27 16:38:37]

Please take a look.

[rharding, 2013-08-27 16:54:45]

LGTM thanks for the updates!

[jeff.pihach, 2013-08-27 16:55:01]

LGTM Thanks for putting in the time to switch this over!

Almost all of your assertions have the params switched. They should be (actual,
expected) - I'd like to see this corrected but I'll leave the final decision up
to you.

https://codereview.appspot.com/13286043/diff/1/test/test_app.js
File test/test_app.js (right):

https://codereview.appspot.com/13286043/diff/1/test/test_app.js#newcode343
test/test_app.js:343: assert.equal('Login', message.Request);
The syntax here is reversed

https://codereview.appspot.com/13286043/diff/1/test/test_app.js#newcode421
test/test_app.js:421: assert.equal(1, conn.messages.length);
reversed

https://codereview.appspot.com/13286043/diff/1/test/test_charm_view.js
File test/test_charm_view.js (right):

https://codereview.appspot.com/13286043/diff/1/test/test_charm_view.js#newcod...
test/test_charm_view.js:189: assert.equal('ServiceDeploy', msg.Request);
this is backwards, the syntax is `assert.equal(actual, expected)`

https://codereview.appspot.com/13286043/diff/1/test/test_endpoints.js
File test/test_endpoints.js (right):

https://codereview.appspot.com/13286043/diff/1/test/test_endpoints.js#newcode543
test/test_endpoints.js:543: assert.equal('ServiceGet',
conn.last_message().Request);
The syntax here is reversed.

https://codereview.appspot.com/13286043/diff/1/test/test_ghost_inspector.js
File test/test_ghost_inspector.js (right):

https://codereview.appspot.com/13286043/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:151: assert.deepEqual(config, params.Config);
all reversed

[frankban, 2013-08-27 17:07:40]

*** Submitted:

Switch the default environment to Go.

Fixed and cleaned up all the failing tests.

R=jeff.pihach
CC=
https://codereview.appspot.com/13286043

[frankban, 2013-08-27 17:08:35]

On 2013/08/27 16:55:01, jeff.pihach wrote:
> LGTM Thanks for putting in the time to switch this over!
> 
> Almost all of your assertions have the params switched. They should be
(actual,
> expected) - I'd like to see this corrected but I'll leave the final decision
up
> to you.

As discussed on IRC, we can fix this (a bit surprising) problem later 
in a more mechanical branch specific to this goal.
Thank you both for the reviews!