Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 132820044: code review 132820044: misc/nacl: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dave
Modified:
10 years, 8 months ago
Reviewers:
gobot, dvyukov, josharian
CC:
golang-codereviews, dvyukov
Visibility:
Public.

Description

misc/nacl: fix build Add gofmt.go and gofmt_test.go as they are part of the test data set. See CL 130440043.

Patch Set 1 #

Patch Set 2 : diff -r 2078c3f47344f940855793def02df9c3b5728474 https://code.google.com/p/go #

Patch Set 3 : diff -r 2078c3f47344f940855793def02df9c3b5728474 https://code.google.com/p/go #

Patch Set 4 : diff -r 2078c3f47344f940855793def02df9c3b5728474 https://code.google.com/p/go #

Patch Set 5 : diff -r 2078c3f47344f940855793def02df9c3b5728474 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M misc/nacl/testzip.proto View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dave_cheney.net
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 8 months ago (2014-08-22 08:20:06 UTC) #1
dvyukov
LGTM
10 years, 8 months ago (2014-08-22 08:33:24 UTC) #2
dave_cheney.net
*** Submitted as https://code.google.com/p/go/source/detail?r=a85c5a932a31 *** misc/nacl: fix build Add gofmt.go and gofmt_test.go as they are ...
10 years, 8 months ago (2014-08-22 08:36:20 UTC) #3
gobot
This CL appears to have broken the windows-386 builder. See http://build.golang.org/log/58fb0b4a3ba050ce3dd66737a085a98e3bfe8c92
10 years, 8 months ago (2014-08-22 08:59:49 UTC) #4
josharian
10 years, 8 months ago (2014-08-22 13:35:02 UTC) #5
Message was sent while issue was closed.
LGTM. Thanks, Dave.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b