code review 132770044: cmd/api: reduce stutter in runtime type stubs

cmd/api: reduce stutter in runtime type stubs

[josharian, 2014-08-21 16:16:28]

Hello khr@golang.org (cc: dvyukov@google.com,
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[khr1, 2014-08-21 17:07:02]

LGTM


On Thu, Aug 21, 2014 at 9:16 AM, <josharian@gmail.com> wrote:

> Reviewers: khr,
>
> Message:
> Hello khr@golang.org (cc: dvyukov@google.com,
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/api: reduce stutter in runtime type stubs
>
> Please review this at https://codereview.appspot.com/132770044/
>
> Affected files (+6, -4 lines):
>   M src/cmd/api/goapi.go
>
>
> Index: src/cmd/api/goapi.go
> ===================================================================
> --- a/src/cmd/api/goapi.go
> +++ b/src/cmd/api/goapi.go
> @@ -378,10 +378,12 @@
>         }
>         if w.context != nil && file == fmt.Sprintf("zruntime_defs_%s_%s.go",
> w.context.GOOS, w.context.GOARCH) {
>                 // Just enough to keep the api checker happy.
> -               src := "package runtime; type maptype struct{}; type _type
> struct{}; type alg struct{};" +
> -                       " type mspan struct{}; type m struct{}; type lock
> struct{}; type slicetype struct{};" +
> -                       " type iface struct{}; type eface struct{}; type
> interfacetype struct{}; type itab struct{};" +
> -                       " type mcache struct{}; type bucket struct{}"
> +               src := "package runtime; type (" +
> +                       " maptype struct{}; _type struct{}; alg struct{};"
> +
> +                       " mspan struct{}; m struct{}; lock struct{};
> slicetype struct{};" +
> +                       " iface struct{}; eface struct{}; interfacetype
> struct{}; itab struct{};" +
> +                       " mcache struct{}; bucket struct{};" +
> +                       ")"
>                 f, err = parser.ParseFile(fset, filename, src, 0)
>                 if err != nil {
>                         log.Fatalf("incorrect generated file: %s", err)
>
>
>

[josharian, 2014-08-21 17:16:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=c72521f4230d ***

cmd/api: reduce stutter in runtime type stubs

LGTM=khr
R=khr
CC=dvyukov, golang-codereviews
https://codereview.appspot.com/132770044

[gobot, 2014-08-21 19:45:50]

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/1e30833270a528f5c0d5b00a88b955c490b584fd

[josharian, 2014-08-21 19:47:04]

Wolf.

On Thu, Aug 21, 2014 at 12:45 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/1e30833270a528f5c0d5b00a88b955c490b584fd
>
> https://codereview.appspot.com/132770044/