Issue 13276043: Update ghost inspector to generate charm icons

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13276043: Update ghost inspector to generate charm icons

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rharding

Modified:
10 years, 7 months ago

Reviewers:
mp+182374, jeff.pihach, matthew.scott

Visibility:
Public.

Description

Update ghost inspector to generate charm icons - The icon in the ghost inspector needs to come from the store - This updates the viewlet to add the icon property and to use it in the template - Simple test to check that the store value comes through in the render. QA: With the service inspector flag enabled (:flags:/serviceInspector) deploy a charm into the environment and the charm's icon should show in the top left of the ghost inspector where before, there was the default icon only. https://code.launchpad.net/~rharding/juju-gui/ghost-icon/+merge/182374 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -25 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/inspector-header.handlebars	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	app/views/viewlets/inspector-header.js	View	1 2	1 chunk	+5 lines, -18 lines	0 comments	Download
M	lib/views/juju-inspector.less	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/test_ghost_inspector.js	View	1 2	2 chunks	+10 lines, -2 lines	0 comments	Download
M	test/test_inspector_overview.js	View	1 2	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rharding

10 years, 7 months ago (2013-08-27 16:06:27 UTC) #6

*** Submitted:

Update ghost inspector to generate charm icons

- The icon in the ghost inspector needs to come from the store
- This updates the viewlet to add the icon property and to use it in the
template
- Simple test to check that the store value comes through in the render.

QA:

With the service inspector flag enabled (:flags:/serviceInspector) deploy a
charm into the environment and the charm's icon should show in the top left of
the ghost inspector where before, there was the default icon only.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/13276043

Expand All Messages | Collapse All Messages