Issue 13274044: Parse V1 certificates correctly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13274044: Parse V1 certificates correctly

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by ekasper

Modified:
10 years, 8 months ago

Reviewers:
Eran

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Parse V1 certificates correctly

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/python/ct/crypto/cert.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Eran

On 2013/08/30 11:05:31, Eran wrote: > What, no extensions?! > LGTM Actually, a test would ...

10 years, 8 months ago (2013-08-30 11:08:53 UTC) #3

ekasper

10 years, 8 months ago (2013-08-30 11:13:09 UTC) #4

Will do in a follow-up CL.


On Fri, Aug 30, 2013 at 12:08 PM, <eranm@google.com> wrote:

> On 2013/08/30 11:05:31, Eran wrote:
>
>> What, no extensions?!
>> LGTM
>>
>
> Actually, a test would be nice. Could you get an offending certificate
> and put it in the testdata dir?
>
>
https://codereview.appspot.**com/13274044/<https://codereview.appspot.com/132...
>

Expand All Messages | Collapse All Messages