Rename BrowserCharm model to just Charm

test/test_browser_charm_details.js

 /*
 This file is part of the Juju GUI, which lets users view and manage Juju
 environments within a graphical interface (https://launchpad.net/juju-gui).
 Copyright (C) 2012-2013 Canonical Ltd.
 
 This program is free software: you can redistribute it and/or modify it under
 the terms of the GNU Affero General Public License version 3, as published by
 the Free Software Foundation.
 
 This program is distributed in the hope that it will be useful, but WITHOUT
@@ skipping 62 matching lines @@
 
     after(function() {
       cleanIconHelper();
     });
 
     it('renders for inspector mode correctly', function() {
       var data = utils.loadFixture('data/browsercharm.json', true);
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
       view = new CharmView({
-        charm: new models.BrowserCharm(data.charm),
+        charm: new models.Charm(data.charm),
         container: utils.makeContainer(),
         forInspector: true
       });
 
       view.render();
       assert.isNull(view.get('container').one('.heading'));
       // There is no 'related charms' tab to display.
       assert.equal(view.get('container').all('.bws-related-charms').size(), 0);
     });
 
     // Return the charm heading node included in the charm detail view.
     var makeHeading = function(is_subordinate) {
       var data = utils.loadFixture('data/browsercharm.json', true);
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
       data.charm.is_subordinate = is_subordinate;
       view = new CharmView({
-        charm: new models.BrowserCharm(data.charm),
+        charm: new models.Charm(data.charm),
         container: utils.makeContainer()
       });
       view.render();
       var heading = view.get('container').one('.heading');
       assert.isNotNull(heading);
       return heading;
     };
 
     it('avoids showing the subordinate message for non-subordinate charms',
        function() {
          var heading = makeHeading(false);
          assert.notInclude(heading.getContent(), 'Subordinate charm');
        });
 
     it('shows the subordinate message if the charm is a subordinate',
        function() {
          var heading = makeHeading(true);
          assert.include(heading.getContent(), 'Subordinate charm');
        });
 
     it('renders local charms for inspector mode correctly', function() {
       var data = utils.loadFixture('data/browsercharm.json', true);
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
       data.charm.url = 'local:precise/apache2-10';
-      var charm = new models.BrowserCharm(data.charm);
+      var charm = new models.Charm(data.charm);
       charm.set('scheme', 'local');
       view = new CharmView({
         charm: charm,
         container: utils.makeContainer(),
         forInspector: true
       });
 
       view.render();
       assert.isNull(view.get('container').one('.heading'));
       assert.isNull(view.get('container').one('#bws-readme'));
@@ skipping 11 matching lines @@
             response: {
               results: [{
                 responseText: 'README content.'
               }]
             }
           });
         }
       });
 
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install',
             'readme.rst'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo'}
         }),
         container: utils.makeContainer(),
         store: fakeStore
       });
       view.render();
       var links = container.all('#sharing a');
       assert.equal(links.size(), 3);
     });
 
     it('should be able to locate a readme file', function() {
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install',
             'readme.rst'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo' }
         })
       });
       view._locateReadme().should.eql('readme.rst');
 
       // Matches for caps as well
       view.get('charm').set('files', [
         'hooks/install',
         'README.md'
       ]);
       view._locateReadme().should.eql('README.md');
     });
 
     it('can generate source and revno links from its charm', function() {
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install',
             'readme.rst'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo'}
         })
       });
       var url = view._getSourceLink();
       assert.equal('http://bazaar.launchpad.net/~foo/files', url);
       assert.equal(
           'http://bazaar.launchpad.net/~foo/revision/1',
           view._getRevnoLink(url, 1));
     });
 
     it('can generate useful display data for commits', function() {
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install',
             'readme.rst'
           ],
           id: 'precise/ceph-9',
           code_source: {
             location: 'lp:~foo'
           }
         })
       });
@@ skipping 37 matching lines @@
               results: [{
                 responseText: 'README content.'
               }]
             }
           });
         }
       });
 
       view = new CharmView({
         activeTab: '#bws-readme',
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install',
             'readme.rst'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo'}
         }),
         container: utils.makeContainer(),
         store: fakeStore
       });
 
       view.render();
 
       Y.one('#bws-readme').get('text').should.eql('README content.');
     });
 
     // EVENTS
     it('should catch when the add control is clicked', function(done) {
       view = new CharmView({
         activeTab: '#bws-readme',
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo' }
         }),
         container: utils.makeContainer()
       });
 
       // Hook up to the callback for the click event.
       view._addCharmEnvironment = function(ev) {
         ev.halt();
         Y.one('#bws-readme h3').get('text').should.eql('Charm has no README');
         done();
       };
 
       view.render();
       node.one('.charm .add').simulate('click');
     });
 
 
     it('_addCharmEnvironment displays the config panel', function(done) {
       var fakeStore = new Y.juju.charmworld.APIv2({});
       fakeStore.iconpath = function() {
         return 'charm icon url';
       };
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install'
           ],
           id: 'precise/ceph-9',
           url: 'cs:precise/ceph-9',
           code_source: { location: 'lp:~foo' },
           options: {
             configName: 'test'
           }
         }),
@@ skipping 19 matching lines @@
             response: {
               results: [{
                 responseText: 'install hook content.'
               }]
             }
           });
         }
       });
 
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'hooks/install',
             'readme.rst'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo' }
         }),
         container: utils.makeContainer(),
         store: fakeStore
       });
@@ skipping 23 matching lines @@
                   '============='
                 ].join('\n')
               }]
             }
           });
         }
       });
 
       view = new CharmView({
         activeTab: '#bws-readme',
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'readme.md'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo' }
         }),
         container: utils.makeContainer(),
         store: fakeStore
       });
 
       view.render();
       Y.one('#bws-readme').get('innerHTML').should.eql(
           '<h1>README Header</h1>');
     });
 
     it('should display the config data in the config tab', function() {
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo' },
           options: {
             'client-port': {
               'default': 9160,
               'description': 'Port for client communcation',
               'type': 'int'
             }
           }
         }),
         container: utils.makeContainer()
       });
       view.render();
 
       Y.one('#bws-configuration dd div').get('text').should.eql(
           'Default: 9160');
       Y.one('#bws-configuration dd p').get('text').should.eql(
           'Port for client communcation');
     });
 
     it('_buildQAData properly summerizes the scores', function() {
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'readme.md'
           ],
           id: 'precise/ceph-9',
           is_approved: true,
           code_source: { location: 'lp:~foo' }
         })
       });
       var data = utils.loadFixture('data/qa.json', true);
       var processed = view._buildQAData(data);
 
       // We store a number of summary bits to help the template render the
       // scores correctly.
       processed.totalAvailable.should.eql(38);
       processed.totalScore.should.eql(13);
       processed.questions[0].score.should.eql(3);
       assert.ok(processed.charm.is_approved);
 
     });
 
     it('does not blow up when the scores from the api is null', function() {
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [
             'readme.md'
           ],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo' }
         })
       });
       var data = utils.loadFixture('data/qa.json', true);
       // munge the data so that scores is null.
       data.scores = null;
@@ skipping 18 matching lines @@
             response: {
               results: [{
                 responseText: fakedata
               }]
             }
           });
         }
       });
 
       view = new CharmView({
-        charm: new models.BrowserCharm({
+        charm: new models.Charm({
           files: [],
           id: 'precise/ceph-9',
           code_source: { location: 'lp:~foo' }
         }),
         renderTo: testContainer,
         store: fakeStore
       });
 
       view.render();
       // Force the loading of the qa div.
@@ skipping 14 matching lines @@
       assert.ok(foundNode);
       // Little cleanup.
       testContainer.remove(true);
     });
 
     it('should catch when the open log is clicked', function(done) {
       var data = utils.loadFixture('data/browsercharm.json', true);
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
       view = new CharmView({
-        charm: new models.BrowserCharm(data.charm),
+        charm: new models.Charm(data.charm),
         container: utils.makeContainer()
       });
 
       // Hook up to the callback for the click event.
       view._toggleLog = function(ev) {
         ev.halt();
         done();
       };
 
       view.render();
       node.one('.changelog .expand').simulate('click');
     });
 
     it('changelog is reformatted and displayed', function() {
       var data = utils.loadFixture('data/browsercharm.json', true);
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
       view = new CharmView({
-        charm: new models.BrowserCharm(data.charm),
+        charm: new models.Charm(data.charm),
         container: utils.makeContainer()
       });
 
       view.render();
       // Basics that we have the right number of nodes.
       node.all('.remaining li').size().should.eql(9);
       node.all('.first p').size().should.eql(1);
 
       // The reminaing starts out hidden.
       assert(node.one('.changelog .remaining').hasClass('hidden'));
     });
 
     it('_getInterfaceIntroFlag sets the flag for no requires, no provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
               },
               'requires': {
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'noRequiresNoProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for no requires, 1 provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
                 'foo': {}
               },
               'requires': {
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'noRequiresOneProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for no requires, many provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
                 'foo': {},
                 'two': {}
               },
               'requires': {
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'noRequiresManyProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for 1 requires, no provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
               },
               'requires': {
                 'foo': {}
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'oneRequiresNoProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for 1 requires, 1 provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
                 'foo': {}
               },
               'requires': {
                 'foo': {}
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'oneRequiresOneProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for 1 requires, many provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
                 'foo': {},
                 'two': {}
               },
               'requires': {
                 'foo': {}
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'oneRequiresManyProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for many requires, no provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
               },
               'requires': {
                 'foo': {},
                 'two': {}
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'manyRequiresNoProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for many requires, 1 provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
                 'foo': {}
               },
               'requires': {
                 'foo': {},
                 'two': {}
               }
             }
           });
           view = new CharmView({
             charm: charm
           });
           var interfaceIntro = view._getInterfaceIntroFlag(
               charm.get('requires'), charm.get('provides'));
           assert(Y.Object.hasKey(interfaceIntro, 'manyRequiresOneProvides'));
         });
 
     it('_getInterfaceIntroFlag sets the flag for many requires, many provides',
         function() {
-          var charm = new models.BrowserCharm({
+          var charm = new models.Charm({
             files: [],
             id: 'precise/ceph-9',
             relations: {
               'provides': {
                 'foo': {},
                 'two': {}
               },
               'requires': {
                 'foo': {},
                 'two': {}
@@ skipping 13 matching lines @@
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
       // Add a failing test to the charm data.
       data.charm.tested_providers = {
         'ec2': 'FAILURE',
         'local': 'SUCCESS',
         'openstack': 'FAILURE'
       };
 
       view = new CharmView({
-        charm: new models.BrowserCharm(data.charm),
+        charm: new models.Charm(data.charm),
         container: utils.makeContainer()
       });
 
       view.render();
       // Basics that we have the right number of nodes.
       node.all('.providers .successes li').size().should.eql(1);
       node.all('.providers .failures li').size().should.eql(2);
     });
 
     it('shows and hides an indicator', function(done) {
       var hit = 0;
 
       var data = utils.loadFixture('data/browsercharm.json', true);
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
       view = new CharmView({
-        charm: new models.BrowserCharm(data.charm),
+        charm: new models.Charm(data.charm),
         container: utils.makeContainer()
       });
 
       view.showIndicator = function() {
         hit += 1;
       };
       view.hideIndicator = function() {
         hit += 1;
         hit.should.equal(2);
         done();
       };
       view.render();
     });
 
     it('selects the proper tab when given one', function() {
       var data = utils.loadFixture('data/browsercharm.json', true);
       // We don't want any files so we don't have to mock/load them.
       data.charm.files = [];
 
       view = new CharmView({
         activeTab: '#bws-configuration',
-        charm: new models.BrowserCharm(data.charm),
+        charm: new models.Charm(data.charm),
         container: utils.makeContainer()
       });
 
       view.render();
 
       // We've selected the activeTab specified.
       var selected = view.get('container').one('.yui3-tab-selected a');
       assert.equal(selected.getAttribute('href'), '#bws-configuration');
     });
 
@@ skipping 11 matching lines @@
             response: {
               results: [{
                 responseText: utils.loadFixture('data/related.json')
               }]
             }
           });
         }
       });
 
       view = new CharmView({
-        charm: new models.BrowserCharm(data),
+        charm: new models.Charm(data),
         isFullscreen: true,
         renderTo: testContainer,
         store: fakeStore
       });
       view.render();
 
       // We've selected the activeTab specified.
       var tokens = view.get('container').all('.charm-token');
       assert.equal(tokens.size(), 5);
 
@@ skipping 26 matching lines @@
               results: [{
                 responseText: utils.loadFixture('data/related.json')
               }]
             }
           });
         }
       });
 
       view = new CharmView({
         activeTab: '#bws-related-charms',
-        charm: new models.BrowserCharm(data),
+        charm: new models.Charm(data),
         isFullscreen: true,
         renderTo: testContainer,
         store: fakeStore
       });
       view.render();
 
       assert.equal(
           testContainer.all('#bws-related-charms .charm-token').size(),
           9);
       assert.isTrue(view.loadedRelatedInterfaceCharms);
@@ skipping 14 matching lines @@
               results: [{
                 responseText: utils.loadFixture('data/related.json')
               }]
             }
           });
         }
       });
 
       view = new CharmView({
         activeTab: '#bws-related-charms',
-        charm: new models.BrowserCharm(data),
+        charm: new models.Charm(data),
         isFullscreen: true,
         renderTo: testContainer,
         store: fakeStore
       });
 
       var origLoadRelatedCharms = view._loadRelatedCharms;
       var state = {
         loadCount: 0,
         hitTabRender: false,
         hitRelatedRender: false
@@ skipping 30 matching lines @@
               results: [{
                 responseText: utils.loadFixture('data/related.json')
               }]
             }
           });
         }
       });
 
       view = new CharmView({
         activeTab: '#bws-does-not-exist',
-        charm: new models.BrowserCharm(data),
+        charm: new models.Charm(data),
         isFullscreen: true,
         renderTo: testContainer,
         store: fakeStore
       });
       view.render();
 
       assert.equal(
           testContainer.one('.yui3-tab-selected a').getAttribute('href'),
           '#bws-summary');
     });
 
   });
 
 })();