Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(189)

Issue 13273047: Rename BrowserCharm model to just Charm

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rharding
Modified:
10 years, 7 months ago
Reviewers:
mp+186038, gary.poster
Visibility:
Public.

Description

Rename BrowserCharm model to just Charm - This is the last bit of unifying the charm models. - Mechanical change of BrowserCharm to Charm for model/model list. QA --- Try to hit things that load the model. Most things should be a matter of tests passing, but a quick qa through - browser - performing a search - deploying the charm - opening the details view from the inspector https://code.launchpad.net/~rharding/juju-gui/browsercharm-charm/+merge/186038 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Rename BrowserCharm model to just Charm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -127 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 3 chunks +8 lines, -8 lines 0 comments Download
M app/models/models.js View 2 chunks +2 lines, -2 lines 0 comments Download
M app/store/charm.js View 3 chunks +3 lines, -3 lines 0 comments Download
M app/subapps/browser/browser.js View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/charm.js View 3 chunks +3 lines, -3 lines 0 comments Download
M app/subapps/browser/views/charmresults.js View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/editorial.js View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/search.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/charm.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/topology/service.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/viewlets/inspector-header.js View 1 chunk +1 line, -1 line 0 comments Download
M app/widgets/charm-token.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/test_browser_charm_details.js View 34 chunks +34 lines, -34 lines 0 comments Download
M test/test_browser_search_view.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_charm_configuration.js View 14 chunks +14 lines, -14 lines 0 comments Download
M test/test_charm_panel.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charm_store.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_conflict_ux.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_endpoints.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/test_ghost_inspector.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_charm.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_inspector_overview.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_settings.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_model.js View 22 chunks +29 lines, -29 lines 0 comments Download
M test/test_model_controller.js View 3 chunks +5 lines, -5 lines 0 comments Download
M test/test_service_config_view.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_service_view.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_unit_view.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 7 months ago (2013-09-17 13:41:15 UTC) #1
gary.poster
LGTM. Thank you! Thanks for bringing jcsackett's awesome work to completion. Comments from IRC: <gary_poster> ...
10 years, 7 months ago (2013-09-17 14:00:57 UTC) #2
bac
LGMT and QA OK
10 years, 7 months ago (2013-09-17 15:03:08 UTC) #3
rharding
10 years, 7 months ago (2013-09-17 15:16:29 UTC) #4
*** Submitted:

Rename BrowserCharm model to just Charm

- This is the last bit of unifying the charm models.
- Mechanical change of BrowserCharm to Charm for model/model list.


QA
---

Try to hit things that load the model. Most things should be a matter of tests
passing, but a quick qa through

- browser
- performing a search
- deploying the charm
- opening the details view from the inspector

R=gary.poster, bac
CC=
https://codereview.appspot.com/13273047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b