Issue 13272050: code review 13272050: cmd/5l: fix handling of RET.EQ in wrapper function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13272050: code review 13272050: cmd/5l: fix handling of RET.EQ in wrapper function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rsc

Modified:
11 years, 8 months ago

Reviewers:
minux1, dave

CC:
ken2, golang-dev, khr

Visibility:
Public.

Description

cmd/5l: fix handling of RET.EQ in wrapper function Keith is too clever for me.

Patch Set 1 #

Patch Set 2 : diff -r 6e09054f1222 https://code.google.com/p/go #

Patch Set 3 : diff -r 6e09054f1222 https://code.google.com/p/go #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/cmd/5l/noop.c	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com, khr), I'd like you to review this change to https://code.google.com/p/go

11 years, 8 months ago (2013-09-13 03:50:48 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=d428d4ae674f *** cmd/5l: fix handling of RET.EQ in wrapper function Keith is ...

11 years, 8 months ago (2013-09-13 03:50:54 UTC) #2

minux1

I can confirm that it fixed the weird testing bug on arm. LGTM.

11 years, 8 months ago (2013-09-13 04:21:07 UTC) #3

dave_cheney.net

11 years, 8 months ago (2013-09-13 04:54:17 UTC) #4

Thanks Russ.

On Fri, Sep 13, 2013 at 2:21 PM,  <minux.ma@gmail.com> wrote:
> I can confirm that it fixed the weird testing bug on arm.
>
> LGTM.
>
>
> https://codereview.appspot.com/13272050/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Expand All Messages | Collapse All Messages