Issue 13263050: code review 13263050: go.tools/pointer: suppress warnings from unsafe.Pointer...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13263050: code review 13263050: go.tools/pointer: suppress warnings from unsafe.Pointer... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by adonovan

Modified:
10 years, 7 months ago

Reviewers:
crawshaw1

CC:
crawshaw1, golang-dev

Visibility:
Public.

Description

go.tools/pointer: suppress warnings from unsafe.Pointer conversions in the "syscall" package. This is a short-term usability measure. Longer term, we need to audit each conversion to decide whether it should be ignored or modelled by an analytic summary.

Patch Set 1 #

Patch Set 2 : diff -r b54591dcca46 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r b54591dcca46 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 3d3b3db2eb1e https://code.google.com/p/go.tools #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	pointer/gen.go	View	1 2	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 7 months ago (2013-09-11 14:34:55 UTC) #1

adonovan

10 years, 7 months ago (2013-09-12 14:56:39 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=4e3f693f8a44&repo=tools ***

go.tools/pointer: suppress warnings from unsafe.Pointer conversions in the
"syscall" package.

This is a short-term usability measure.
Longer term, we need to audit each conversion to decide
whether it should be ignored or modelled by an analytic
summary.

R=crawshaw
CC=golang-dev
https://codereview.appspot.com/13263050

Expand All Messages | Collapse All Messages