code review 13261048: cmd/go: make it work for code.google.com cloned repositories

cmd/go: make it work for code.google.com cloned repositories

Thanks to beatgammit for the fix.

Fixes issue 5408.

[r, 2013-08-29 03:16:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-29 03:22:42]

No test table addition?


On Wed, Aug 28, 2013 at 8:16 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/go: make it work for code.google.com cloned repositories
>
> Thanks to beatgammit for the fix.
>
> Fixes issue 5408.
>
> Please review this at
https://codereview.appspot.**com/13261048/<https://codereview.appspot.com/132...
>
> Affected files:
>   M src/cmd/go/vcs.go
>
>
> Index: src/cmd/go/vcs.go
> ==============================**==============================**=======
> --- a/src/cmd/go/vcs.go
> +++ b/src/cmd/go/vcs.go
> @@ -569,7 +569,7 @@
>         // Google Code - new syntax
>         {
>                 prefix: "code.google.com/",
> -               re:     `^(?P<root>code\.google\.com/**
> p/(?P<project>[a-z0-9\-]+)(\.(**?P<subrepo>[a-z0-9\-]+))?)(/[**
> A-Za-z0-9_.\-]+)*$`,
> +               re:     `^(?P<root>code\.google\.com/(**
> p|r)/(?P<project>[a-z0-9\-]+)(**\.(?P<subrepo>[a-z0-9\-]+))?)(**
> /[A-Za-z0-9_.\-]+)*$`,
>                 repo:   "https://{root}",
>                 check:  googleCodeVCS,
>         },
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[r, 2013-08-29 03:44:25]

No, but there is a separate CL coming with tests in go.tools/go/vcs.

[r, 2013-08-29 03:51:20]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2013-08-29 04:01:50]

taking the ?: back out of this one anyway. it uses named submatches,
so they're unnecessary and bother me.

[r, 2013-08-29 04:02:07]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-08-29 04:07:41]

LGTM

Does [pr] bother you too?  I don't feel strongly about any of the three ways.

[r, 2013-08-29 04:09:29]

[pr] would be fine too. sure, let's do that.

-rob

[r, 2013-08-29 07:15:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=f974949adf23 ***

cmd/go: make it work for code.google.com cloned repositories

Thanks to beatgammit for the fix.

Fixes issue 5408.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13261048