Get the address correctly from the container.

Get the address correctly from the container.

This is kind of messy, but it does work.
This uses an extra environment variable from the upstart
script to identify the type of container.  MAAS then uses
this when trying to work out the hostname of the machine.

We do need a nicer way to get this done.  We also want to
move the environment variables from the upstart script
into the agent config, but this will be a follow up branch.

https://code.launchpad.net/~thumper/juju-core/container-address/+merge/182271

(do not edit description out of merge proposal)

[thumper, 2013-08-27 05:42:58]

Please take a look.

[jameinel, 2013-08-27 06:06:36]

I fully support moving away from environment variables into doing this properly
via something like "agent.conf".

However, I'd rather see us have containers working on MaaS today than wait for
agent.conf refactoring, so this seems ok to me.

Can you add a comment to the "machineConfig.MachineEnvironment" line, to make it
stand out a bit more that we want to change how that works?

Everything else seems pretty straightforward. I wonder if we want a basic smoke
test for utils.GetAddressForInterface.

We could ask for the details of "eth0" and test that we either get a meaningful
error back, or we get an ipv4 address.

LGTM

[fwereade, 2013-08-27 14:36:18]

LGTM. Are we now settled on using EnvironProvider methods internally to get
addresses across the board? I forget some of the discussions...

[thumper, 2013-08-27 22:55:21]

On 2013/08/27 06:06:36, jameinel wrote:
> I fully support moving away from environment variables into doing this
properly
> via something like "agent.conf".
> 
> However, I'd rather see us have containers working on MaaS today than wait for
> agent.conf refactoring, so this seems ok to me.
> 
> Can you add a comment to the "machineConfig.MachineEnvironment" line, to make
it
> stand out a bit more that we want to change how that works?

OK.

> Everything else seems pretty straightforward. I wonder if we want a basic
smoke
> test for utils.GetAddressForInterface.

We do have tests around the methods that GetAddressForInterface uses.

[thumper, 2013-08-27 22:55:49]

On 2013/08/27 14:36:18, fwereade wrote:
> LGTM. Are we now settled on using EnvironProvider methods internally to get
> addresses across the board? I forget some of the discussions...

I'm not entirely sure, but since I'm still waiting to hear back on a lot of the
addressability issues, this will work for now.