code review 13257044: cmd/gc: tag builtin error, byte, rune to avoid exportin...

cmd/gc: tag builtin error, byte, rune to avoid exporting them.

Fixes issue 5910.
Fixes issue 6260.

[remyoudompheng, 2013-08-27 06:30:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[DMorsing, 2013-08-27 07:58:16]

Reading back on this, I'm a bit confused as to why this works at all. We pull
builtins into localpkg, but we never set s->def, so any local lookup on it
should fail.

I touched the table lookup last, so it's probably a bug :)

[remyoudompheng, 2013-08-27 08:18:21]

well, at least it should be the same for the table and for error/byte/rune.

2013/8/27, daniel.morsing@gmail.com <daniel.morsing@gmail.com>:
> Reading back on this, I'm a bit confused as to why this works at all. We
> pull builtins into localpkg, but we never set s->def, so any local
> lookup on it should fail.
>
> I touched the table lookup last, so it's probably a bug :)
>
> https://codereview.appspot.com/13257044/
>

[DMorsing, 2013-08-27 08:22:16]

On 2013/08/27 08:18:21, remyoudompheng wrote:
> well, at least it should be the same for the table and for error/byte/rune.
> 

LGTM on that account.

I'm going to look at this later. There are probably a couple of undiscovered
inlining bugs hidden in that quirk.

[DMorsing, 2013-08-27 14:47:08]

Ok, seems like I just plain forgot how the symbol table worked during parsing.
Feel free to submit.

[remyoudompheng, 2013-08-27 19:18:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=1e3289919b26 ***

cmd/gc: tag builtin error, byte, rune to avoid exporting them.

Fixes issue 5910.
Fixes issue 6260.

R=golang-dev, daniel.morsing
CC=golang-dev
https://codereview.appspot.com/13257044