Issue 13256050: code review 13256050: go.oracle: freevars: don't report free identifiers defi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13256050: code review 13256050: go.oracle: freevars: don't report free identifiers defi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by adonovan

Modified:
10 years, 7 months ago

Reviewers:
gri

CC:
crawshaw1, gri, golang-dev

Visibility:
Public.

Description

go.oracle: freevars: don't report free identifiers defined in package scope. The existing check rejected only free identifiers defined in file scope, i.e. just imports. + regression test.

Patch Set 2 : diff -r b54591dcca46 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r b54591dcca46 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 4 : diff -r 4e3f693f8a44 https://code.google.com/p/go.tools #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
M	oracle/freevars.go	View	1 2 3	2 chunks	+7 lines, -4 lines	0 comments	Download
M	oracle/testdata/src/main/freevars.go	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	oracle/testdata/src/main/freevars.golden	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello crawshaw@google.com (cc: golang-dev@googlegroups.com, gri@golang.org), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 7 months ago (2013-09-11 14:27:41 UTC) #1

gri

LGTM https://codereview.appspot.com/13256050/diff/6001/oracle/freevars.go File oracle/freevars.go (right): https://codereview.appspot.com/13256050/diff/6001/oracle/freevars.go#newcode68 oracle/freevars.go:68: return nil // e.g. interface method TODO(adonovan): what ...

10 years, 7 months ago (2013-09-11 22:32:47 UTC) #2

adonovan

https://codereview.appspot.com/13256050/diff/6001/oracle/freevars.go File oracle/freevars.go (right): https://codereview.appspot.com/13256050/diff/6001/oracle/freevars.go#newcode68 oracle/freevars.go:68: return nil // e.g. interface method TODO(adonovan): what else? ...

10 years, 7 months ago (2013-09-12 14:58:57 UTC) #3

adonovan

10 years, 7 months ago (2013-09-12 15:00:23 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=2c39134a2b94&repo=tools ***

go.oracle: freevars: don't report free identifiers defined in package scope.

The existing check rejected only free identifiers defined in
file scope, i.e. just imports.

+ regression test.

R=crawshaw, gri
CC=golang-dev
https://codereview.appspot.com/13256050

Expand All Messages | Collapse All Messages