Issue 13256046: code review 13256046: image/color/palette: move Plan9Palette and WebSafePalet...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13256046: code review 13256046: image/color/palette: move Plan9Palette and WebSafePalet... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by nigeltao

Modified:
11 years, 8 months ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

image/color/palette: move Plan9Palette and WebSafePalette out of the image/color package into their own package. They require some non- trivial init-time code (interface conversions, currently 40KiB of text) that would otherwise burden any Go program that imported image/color.

Patch Set 1 #

Patch Set 2 : diff -r 6939fe74ea98 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6939fe74ea98 https://code.google.com/p/go/ #

Patch Set 4 : diff -r dd674dca7393 https://code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+507 lines, -500 lines)			Patch
M	src/pkg/image/color/palette/gen.go	View	1	5 chunks	+12 lines, -9 lines	0 comments	Download
M	src/pkg/image/color/palette/palette.go	View	1	2 chunks	+481 lines, -478 lines	0 comments	Download
M	src/pkg/image/gif/reader_test.go	View	1	7 chunks	+11 lines, -11 lines	0 comments	Download
M	src/pkg/image/gif/writer.go	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-08-30 03:57:00 UTC) #1

nigeltao

11 years, 8 months ago (2013-08-30 06:03:31 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a2c595669bb6 ***

image/color/palette: move Plan9Palette and WebSafePalette out of the
image/color package into their own package. They require some non-
trivial init-time code (interface conversions, currently 40KiB of text)
that would otherwise burden any Go program that imported image/color.

R=r
CC=golang-dev
https://codereview.appspot.com/13256046

Expand All Messages | Collapse All Messages