Issue 13255052: Remove old Charm and CharmList.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13255052: Remove old Charm and CharmList.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by bac

Modified:
10 years, 7 months ago

Reviewers:
j.c.sackett, mp+187263

Visibility:
Public.

Description

Remove old Charm and CharmList. https://code.launchpad.net/~bac/juju-gui/OneTrueCharmModel/+merge/187263 (do not edit description out of merge proposal)

Patch Set 2 : Remove old Charm and CharmList. #

Patch Set 3 : Remove old Charm and CharmList. #

Patch Set 4 : Remove old Charm and CharmList. #

Patch Set 5 : Remove old Charm and CharmList. #

Patch Set 6 : Remove old Charm and CharmList. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -278 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/models/charm.js	View	1	3 chunks	+6 lines, -278 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

j.c.sackett

LGTM, with one note about the comment being deleted. https://codereview.appspot.com/13255052/diff/1/app/models/charm.js File app/models/charm.js (left): https://codereview.appspot.com/13255052/diff/1/app/models/charm.js#oldcode111 app/models/charm.js:111: ...

10 years, 7 months ago (2013-09-24 16:07:59 UTC) #2

bac

10 years, 7 months ago (2013-09-24 20:26:17 UTC) #3

*** Submitted:

Remove old Charm and CharmList.

R=j.c.sackett
CC=
https://codereview.appspot.com/13255052

https://codereview.appspot.com/13255052/diff/1/app/models/charm.js
File app/models/charm.js (left):

https://codereview.appspot.com/13255052/diff/1/app/models/charm.js#oldcode111
app/models/charm.js:111: * its environment.
Restored

Expand All Messages | Collapse All Messages