Issue 13255050: code review 13255050: go.crypto/ssh/terminal: fix non-ASCII history.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13255050: code review 13255050: go.crypto/ssh/terminal: fix non-ASCII history. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by agl1

Modified:
10 years, 7 months ago

Reviewers:
r, sfrithjof

CC:
golang-dev, sfrithjof, r

Visibility:
Public.

Description

go.crypto/ssh/terminal: fix non-ASCII history. The length of history buffer entries (which are stored as strings) was being used as the number of runes. This was correct until ff9ce887b46b, which allowed unicode entry, but can now cause a panic when editing history that contains non-ASCII codepoints.

Patch Set 1 #

Patch Set 2 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 6 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	ssh/terminal/terminal.go	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
	M	ssh/terminal/terminal_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

10 years, 7 months ago (2013-09-14 15:58:59 UTC) #1

agl1

10 years, 7 months ago (2013-09-15 16:48:01 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=c923f02daf74&repo=crypto ***

go.crypto/ssh/terminal: fix non-ASCII history.

The length of history buffer entries (which are stored as strings) was
being used as the number of runes. This was correct until ff9ce887b46b,
which allowed unicode entry, but can now cause a panic when editing
history that contains non-ASCII codepoints.

R=golang-dev, sfrithjof, r
CC=golang-dev
https://codereview.appspot.com/13255050

Expand All Messages | Collapse All Messages