Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(330)

Issue 13255050: code review 13255050: go.crypto/ssh/terminal: fix non-ASCII history. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by agl1
Modified:
6 years, 2 months ago
Reviewers:
r, sfrithjof
CC:
golang-dev, sfrithjof, r
Visibility:
Public.

Description

go.crypto/ssh/terminal: fix non-ASCII history. The length of history buffer entries (which are stored as strings) was being used as the number of runes. This was correct until ff9ce887b46b, which allowed unicode entry, but can now cause a panic when editing history that contains non-ASCII codepoints.

Patch Set 1 #

Patch Set 2 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Patch Set 6 : diff -r ff9ce887b46b https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M ssh/terminal/terminal.go View 1 1 chunk +6 lines, -3 lines 0 comments Download
M ssh/terminal/terminal_test.go View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
6 years, 2 months ago (2013-09-14 15:58:59 UTC) #1
sfrithjof
LGTM
6 years, 2 months ago (2013-09-14 18:52:08 UTC) #2
r
LGTM
6 years, 2 months ago (2013-09-14 21:29:17 UTC) #3
agl1
6 years, 2 months ago (2013-09-15 16:48:01 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=c923f02daf74&repo=crypto ***

go.crypto/ssh/terminal: fix non-ASCII history.

The length of history buffer entries (which are stored as strings) was
being used as the number of runes. This was correct until ff9ce887b46b,
which allowed unicode entry, but can now cause a panic when editing
history that contains non-ASCII codepoints.

R=golang-dev, sfrithjof, r
CC=golang-dev
https://codereview.appspot.com/13255050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b