code review 13255049: test/nilptr: add more tests

test/nilptr: add more tests

These tests were suggested in golang.org/issue/6080.
They were fixed as part of the new nil pointer checks
that I added a few weeks ago.

Recording the tests as part of marking the issue closed.

Fixes issue 6080.

[rsc, 2013-09-06 02:37:54]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2013-09-06 02:49:35]

LGTM

[bradfitz, 2013-09-06 02:52:02]

LGTM
 On Sep 5, 2013 7:37 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test/nilptr: add more tests
>
> These tests were suggested in golang.org/issue/6080.
> They were fixed as part of the new nil pointer checks
> that I added a few weeks ago.
>
> Recording the tests as part of marking the issue closed.
>
> Fixes issue 6080.
>
> Please review this at
https://codereview.appspot.**com/13255049/<https://codereview.appspot.com/132...
>
> Affected files (+28, -0 lines):
>   M test/nilptr.go
>
>
> Index: test/nilptr.go
> ==============================**==============================**=======
> --- a/test/nilptr.go
> +++ b/test/nilptr.go
> @@ -40,6 +40,10 @@
>         shouldPanic(p10)
>         shouldPanic(p11)
>         shouldPanic(p12)
> +       shouldPanic(p13)
> +       shouldPanic(p14)
> +       shouldPanic(p15)
> +       shouldPanic(p16)
>  }
>
>  func shouldPanic(f func()) {
> @@ -152,3 +156,27 @@
>         var p *T = nil
>         println(*(&((*p).i)))
>  }
> +
> +// Tests suggested in golang.org/issue/6080.
> +
> +func p13() {
> +       var x *[10]int
> +       y := x[:]
> +       _ = y
> +}
> +
> +func p14() {
> +       println((*[1]int)(nil)[:])
> +}
> +
> +func p15() {
> +       for i := range (*[1]int)(nil)[:] {
> +               _ = i
> +       }
> +}
> +
> +func p16() {
> +       for i, v := range (*[1]int)(nil)[:] {
> +               _ = i + v
> +       }
> +}
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-09-06 03:06:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=58e5ed6b5029 ***

test/nilptr: add more tests

These tests were suggested in golang.org/issue/6080.
They were fixed as part of the new nil pointer checks
that I added a few weeks ago.

Recording the tests as part of marking the issue closed.

Fixes issue 6080.

R=golang-dev, r, bradfitz
CC=golang-dev
https://codereview.appspot.com/13255049