Issue 13254049: Incremental update support for SP 2013

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13254049: Incremental update support for SP 2013 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Tanmay Vartak

Modified:
10 years, 7 months ago

Reviewers:
ejona

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Incremental update support for SP 2013 Code Commit : https://code.google.com/p/plexi/source/detail?r=4172d646bd101da15d582f008a819a0672ed8dcf&repo=sharepoint

Patch Set 2 : with code review comments implemented #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -137 lines)			Patch
	M	src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java	View	1	6 chunks	+122 lines, -130 lines	2 comments	Download
	M	test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java	View		1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ejona

https://codereview.appspot.com/13254049/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/13254049/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode575 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:575: if (site != null) { If you do a ...

10 years, 7 months ago (2013-09-11 17:53:40 UTC) #2

ejona

10 years, 7 months ago (2013-09-11 23:11:45 UTC) #4

LGTM

https://codereview.appspot.com/13254049/diff/6001/src/com/google/enterprise/a...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/13254049/diff/6001/src/com/google/enterprise/a...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:1491: Xml
xml = i.getXml();
Remove whitespace from end of line, since line was not otherwise modified.

https://codereview.appspot.com/13254049/diff/6001/src/com/google/enterprise/a...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:1535: =
list.getMetadata().getScopeID().toLowerCase(Locale.ENGLISH);
Remove whitespace from end of line, since line was not otherwise modified.

Expand All Messages | Collapse All Messages