Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 13253056: Adds service name valid indicator

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by jeff.pihach
Modified:
11 years, 6 months ago
Reviewers:
mp+185916, gary.poster
Visibility:
Public.

Description

Adds service name valid indicator When deploying a charm the service name input box will now show you a checkmark or x depending on other services currently deployed. https://code.launchpad.net/~hatch/juju-gui/service-name-1221668/+merge/185916 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Adds service name valid indicator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -23 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/form-validation-cross.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/form-validation-tick.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M app/models/models.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M app/templates/inspector-header.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/views/ghost-inspector.js View 3 chunks +28 lines, -19 lines 0 comments Download
M app/views/utils.js View 1 chunk +12 lines, -0 lines 0 comments Download
M app/views/viewlets/inspector-header.js View 1 chunk +10 lines, -0 lines 0 comments Download
M lib/views/juju-inspector.less View 1 chunk +10 lines, -0 lines 0 comments Download
M test/test_ghost_inspector.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
jeff.pihach
Please take a look.
11 years, 6 months ago (2013-09-16 19:52:18 UTC) #1
gary.poster
LGTM and qa ok. As discussed, I'd like to see the " 1" removed, ideally. ...
11 years, 6 months ago (2013-09-16 20:31:09 UTC) #2
jeff.pihach
11 years, 6 months ago (2013-09-16 21:31:01 UTC) #3
*** Submitted:

Adds service name valid indicator

When deploying a charm the service name input box will
now show you a checkmark or x depending on other services
currently deployed.

R=gary.poster
CC=
https://codereview.appspot.com/13253056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b