Issue 13253045: cmd/jujud: Disable flaky test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13253045: cmd/jujud: Disable flaky test

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by jameinel

Modified:
10 years, 8 months ago

Reviewers:
axw1, mp+183384

Visibility:
Public.

Description

cmd/jujud: Disable flaky test TestManageStateServesAPI is failing about half the time on the bot. I'd love to have a fix, but until we do I don't want to reject peoples patches incorrectly. https://code.launchpad.net/~jameinel/juju-core/disable-testmanagestateservesapi-1219661/+merge/183384 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : cmd/jujud: Disable flaky test #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujud/machine_test.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw1

LGTM https://codereview.appspot.com/13253045/diff/1/cmd/jujud/machine_test.go File cmd/jujud/machine_test.go (right): https://codereview.appspot.com/13253045/diff/1/cmd/jujud/machine_test.go#newcode381 cmd/jujud/machine_test.go:381: func (s *MachineSuite) DONT_TestManageStateServesAPI(c *gc.C) { I think ...

10 years, 8 months ago (2013-09-02 08:27:00 UTC) #2

jameinel

10 years, 8 months ago (2013-09-02 08:36:07 UTC) #3

Please take a look.

https://codereview.appspot.com/13253045/diff/1/cmd/jujud/machine_test.go
File cmd/jujud/machine_test.go (right):

https://codereview.appspot.com/13253045/diff/1/cmd/jujud/machine_test.go#newc...
cmd/jujud/machine_test.go:381: func (s *MachineSuite)
DONT_TestManageStateServesAPI(c *gc.C) {
On 2013/09/02 08:27:00, axw1 wrote:
> I think it would be better to use c.Skip, just so it's in everybody's faces.

Done.

Expand All Messages | Collapse All Messages