Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(859)

Issue 13252046: code review 13252046: undo CL 10726044 / c9bea548fb6f (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by bradfitz
Modified:
5 years, 5 months ago
Reviewers:
mikio
CC:
golang-dev
Visibility:
Public.

Description

undo CL 10726044 / c9bea548fb6f Breaks build, and has a race. ««« original CL description database/sql: add SetMaxOpenConns Update issue 4805 Add the ability to set an open connection limit. Fixed case where the Conn finalCloser was being called with db.mu locked. Added seperate benchmarks for each path for Exec and Query. Replaced slice based idle pool with list based idle pool. R=bradfitz CC=golang-dev https://codereview.appspot.com/10726044 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r c9bea548fb6f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c9bea548fb6f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -812 lines) Patch
M src/pkg/database/sql/fakedb_test.go View 1 4 chunks +5 lines, -23 lines 0 comments Download
M src/pkg/database/sql/sql.go View 1 13 chunks +39 lines, -220 lines 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 12 chunks +25 lines, -569 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
5 years, 5 months ago (2013-08-30 00:25:54 UTC) #1
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=538f0ff769dd *** undo CL 10726044 / c9bea548fb6f Breaks build, and has a ...
5 years, 5 months ago (2013-08-30 00:26:17 UTC) #2
mikio
5 years, 5 months ago (2013-08-30 00:32:46 UTC) #3
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b