Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 13252045: Only sends the changed config options.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by jeff.pihach
Modified:
10 years, 6 months ago
Reviewers:
rharding, frankban, mp+183048
Visibility:
Public.

Description

Only sends the changed config options. 1) There was a bug with the ghost constraints code which caused it to fail when deploying services on rapi. 2) The GUI now only sends configuration values to juju when those values differ from the defaults. https://code.launchpad.net/~hatch/juju-gui/save-changed-1214087/+merge/183048 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only sends the changed config options. #

Patch Set 3 : Only sends the changed config options. #

Total comments: 12

Patch Set 4 : Only sends the changed config options. #

Patch Set 5 : Only sends the changed config options. #

Patch Set 6 : Only sends the changed config options. #

Patch Set 7 : Only sends the changed config options. #

Patch Set 8 : Only sends the changed config options. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -67 lines) Patch
A [revision details] View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 1 2 3 4 5 6 7 1 chunk +28 lines, -2 lines 0 comments Download
M app/store/env/go.js View 1 2 3 4 5 7 chunks +51 lines, -6 lines 0 comments Download
M app/store/env/python.js View 1 2 3 4 3 chunks +18 lines, -5 lines 0 comments Download
M app/views/ghost-inspector.js View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/inspector.js View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/service.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M app/views/utils.js View 1 2 3 4 5 6 2 chunks +38 lines, -2 lines 0 comments Download
M app/views/viewlets/service-ghost.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/assets/mysql-config.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/test_env_go.js View 1 2 3 4 2 chunks +9 lines, -2 lines 0 comments Download
M test/test_env_python.js View 1 2 3 4 5 chunks +9 lines, -10 lines 0 comments Download
M test/test_fakebackend.js View 1 2 3 4 5 6 7 4 chunks +21 lines, -6 lines 0 comments Download
M test/test_ghost_inspector.js View 1 2 3 4 5 3 chunks +3 lines, -7 lines 0 comments Download
M test/test_sandbox_go.js View 1 2 3 4 5 6 7 10 chunks +50 lines, -12 lines 0 comments Download
M test/test_sandbox_python.js View 1 2 4 chunks +22 lines, -7 lines 0 comments Download
M test/test_service_config_view.js View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M test/test_utils.js View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13
jeff.pihach
Please take a look.
10 years, 7 months ago (2013-08-29 22:18:51 UTC) #1
frankban
Thanks for this branch Jeff. I think there is still some substantial work/clean up to ...
10 years, 7 months ago (2013-08-30 09:00:32 UTC) #2
jeff.pihach
Please take a look.
10 years, 7 months ago (2013-08-30 17:54:16 UTC) #3
jeff.pihach
Please take a look.
10 years, 7 months ago (2013-09-02 16:51:16 UTC) #4
rharding
I think this moves the environment specific logic up to the view/app layer. The inspector ...
10 years, 7 months ago (2013-09-02 21:19:28 UTC) #5
jeff.pihach
Thanks for the review - comments below and changes incoming. I agree with your comments ...
10 years, 7 months ago (2013-09-02 22:26:05 UTC) #6
jeff.pihach
Please take a look.
10 years, 7 months ago (2013-09-02 22:38:07 UTC) #7
jeff.pihach
Please take a look.
10 years, 6 months ago (2013-09-03 09:46:28 UTC) #8
rharding
LGTM thanks for getting this put together!
10 years, 6 months ago (2013-09-03 10:01:54 UTC) #9
jeff.pihach
Please take a look.
10 years, 6 months ago (2013-09-03 14:47:43 UTC) #10
jeff.pihach
Please take a look.
10 years, 6 months ago (2013-09-03 15:47:48 UTC) #11
frankban
LGTM QA ok, thank you Jeff
10 years, 6 months ago (2013-09-03 16:04:02 UTC) #12
jeff.pihach
10 years, 6 months ago (2013-09-03 16:09:36 UTC) #13
*** Submitted:

Only sends the changed config options.

1) There was a bug with the ghost constraints code which
   caused it to fail when deploying services on rapi.

2) The GUI now only sends configuration values to juju when
   those values differ from the defaults.

R=frankban, rharding
CC=
https://codereview.appspot.com/13252045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b