Issue 13249050: api/uniter: Relation and RelationUnit methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13249050: api/uniter: Relation and RelationUnit methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dimitern

Modified:
10 years, 8 months ago

Reviewers:
mue, mp+184254

Visibility:
Public.

Description

api/uniter: Relation and RelationUnit methods Implemented all of the uniter.Relation methods and their tests. Almost finished uniter.RelationUnit methods and tests, except for Settings() and ReadSettings() - these two will come in a follow-up, because uniter.Settings needs to be fully implemented first. https://code.launchpad.net/~dimitern/juju-core/122-api-uniter-relation-and-relationunit-calls/+merge/184254 Requires: https://code.launchpad.net/~dimitern/juju-core/121-api-uniter-split-tests/+merge/184110 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : api/uniter: Relation and RelationUnit methods #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+312 lines, -53 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/uniter/relation.go	View		3 chunks	+17 lines, -17 lines	0 comments	Download
A	state/api/uniter/relation_test.go	View		1 chunk	+100 lines, -0 lines	0 comments	Download
M	state/api/uniter/relationunit.go	View	1	5 chunks	+28 lines, -19 lines	0 comments	Download
M	state/api/uniter/relationunit_test.go	View		1 chunk	+160 lines, -12 lines	0 comments	Download
M	state/api/uniter/unit_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/api/uniter/uniter_test.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mue

LGTM, nice, only minor comment. https://codereview.appspot.com/13249050/diff/1/state/api/uniter/relationunit.go File state/api/uniter/relationunit.go (right): https://codereview.appspot.com/13249050/diff/1/state/api/uniter/relationunit.go#newcode73 state/api/uniter/relationunit.go:73: {Relation: ru.relation.tag, Unit: ru.unit.tag}, ...

10 years, 8 months ago (2013-09-06 09:18:53 UTC) #2

dimitern

10 years, 8 months ago (2013-09-06 09:26:09 UTC) #3

Please take a look.

https://codereview.appspot.com/13249050/diff/1/state/api/uniter/relationunit.go
File state/api/uniter/relationunit.go (right):

https://codereview.appspot.com/13249050/diff/1/state/api/uniter/relationunit....
state/api/uniter/relationunit.go:73: {Relation: ru.relation.tag, Unit:
ru.unit.tag},
On 2013/09/06 09:18:53, mue wrote:
> Would like this as
> 
> {
>     Relation: ...,
>     Unit:     ...,
> }

Done.

https://codereview.appspot.com/13249050/diff/1/state/api/uniter/relationunit....
state/api/uniter/relationunit.go:92: {Relation: ru.relation.tag, Unit:
ru.unit.tag},
On 2013/09/06 09:18:53, mue wrote:
> Ditto.

Done.

Expand All Messages | Collapse All Messages