Change unit replace button to remove

Change unit replace button to remove

This branch also removes the scale unit spinner
because we do not have a targetUnit property in 
Juju.

https://code.launchpad.net/~hatch/juju-gui/replace-to-remove/+merge/182940

(do not edit description out of merge proposal)

[jeff.pihach, 2013-08-29 16:15:13]

Please take a look.

[benjamin.saller, 2013-08-29 16:21:38]

LGTM

Thanks

https://codereview.appspot.com/13249045/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/13249045/diff/1/app/views/inspector.js#newcode939
app/views/inspector.js:939: unitNames.push(unit.siblings('a').get('innerHTML'));
doh

[rharding, 2013-08-29 16:33:33]

LGTM - QA and small question on perf of skipping ability to not need the loop in
one env vs another.

https://codereview.appspot.com/13249045/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/13249045/diff/1/app/views/inspector.js#newcode994
app/views/inspector.js:994: // XXX Remove this loop when we drop python support.
can we not check which env we're in and pass either the list or the one? Is
there any performance benefit to passing the list in one call vs many all the
time?

[jeff.pihach, 2013-08-29 16:45:24]

*** Submitted:

Change unit replace button to remove

This branch also removes the scale unit spinner
because we do not have a targetUnit property in 
Juju.

R=benjamin.saller, rharding
CC=
https://codereview.appspot.com/13249045