code review 132490043: runtime: include os_*.h in the generated Go structs

runtime: include os_*.h in the generated Go structs

Adding the #include to defs.c makes it get processed
by cmd/dist, which writes out Go equivalent for all the
C data structures defined in defs.c.

This in turn makes it necessary to define the Plink type,
used in os_plan9.h, in os_plan9.go. Rename it to _Plink
to avoid being exported.

[rsc, 2014-08-30 17:59:59]

Hello golang-codereviews@googlegroups.com (cc: iant, r),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2014-08-30 21:02:39]

https://codereview.appspot.com/132490043/diff/40001/src/pkg/runtime/os_plan9.go
File src/pkg/runtime/os_plan9.go (right):

https://codereview.appspot.com/132490043/diff/40001/src/pkg/runtime/os_plan9....
src/pkg/runtime/os_plan9.go:30: type _Plink uintptr
If _Plink is added to os_plan9.h, and defs.c #include's os_plan9.h, then I would
expect _plink to be defined in zruntime_defs_....h.  If that is correct, why
define _Plink here?

[rsc, 2014-09-01 00:25:22]

https://codereview.appspot.com/132490043/diff/40001/src/pkg/runtime/os_plan9.go
File src/pkg/runtime/os_plan9.go (right):

https://codereview.appspot.com/132490043/diff/40001/src/pkg/runtime/os_plan9....
src/pkg/runtime/os_plan9.go:30: type _Plink uintptr
On 2014/08/30 21:02:39, iant wrote:
> If _Plink is added to os_plan9.h, and defs.c #include's os_plan9.h, then I
would
> expect _plink to be defined in zruntime_defs_....h.  If that is correct, why
> define _Plink here?

The z file gets struct definitions, not integer type definitions.

[0intro, 2014-09-01 06:57:49]

LGTM

[iant, 2014-09-01 18:42:48]

LGTM

[rsc, 2014-09-01 21:25:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=9ab3b26a6180 ***

runtime: include os_*.h in the generated Go structs

Adding the #include to defs.c makes it get processed
by cmd/dist, which writes out Go equivalent for all the
C data structures defined in defs.c.

This in turn makes it necessary to define the Plink type,
used in os_plan9.h, in os_plan9.go. Rename it to _Plink
to avoid being exported.

LGTM=0intro, iant
R=golang-codereviews, iant, 0intro
CC=golang-codereviews, r
https://codereview.appspot.com/132490043

[gobot, 2014-09-01 21:28:22]

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/1bf3e70879f219d58dbaea9d1e28b43196a84dec