Issue 13248047: code review 13248047: goprotobuf: Make several changes to ErrRequiredNotSet:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13248047: code review 13248047: goprotobuf: Make several changes to ErrRequiredNotSet: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by dsymonds

Modified:
12 years, 2 months ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Make several changes to ErrRequiredNotSet: - Report the full or partial path to the first missing required field (where possible) instead of the message name. - Make it ignorable. Unmarshal and Marshal will continue to decode/encode the full proto.

Patch Set 1 #

Patch Set 2 : diff -r 4794f7baff22 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 4794f7baff22 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 4794f7baff22 https://code.google.com/p/goprotobuf #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -27 lines)			Patch
M	proto/all_test.go	View	1	4 chunks	+67 lines, -3 lines	0 comments	Download
M	proto/decode.go	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download
M	proto/encode.go	View	1	16 chunks	+56 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

12 years, 2 months ago (2013-09-09 01:26:56 UTC) #1

dsymonds

12 years, 2 months ago (2013-09-09 03:19:05 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=b3fe298e0954 ***

goprotobuf: Make several changes to ErrRequiredNotSet:
- Report the full or partial path to the first missing required field (where
possible) instead of the message name.
- Make it ignorable. Unmarshal and Marshal will continue to decode/encode the
full proto.

R=r
CC=golang-dev
https://codereview.appspot.com/13248047

Expand All Messages | Collapse All Messages