Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(144)

Issue 13247046: code review 13247046: cgo: enable cgo on dragonfly

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by varialus
Modified:
10 years, 6 months ago
Reviewers:
iant
CC:
golang-dev, jsing, iant, bradfitz
Visibility:
Public.

Description

cgo: enable cgo on dragonfly Enable cgo for dragonfly/386 and dragonfly/amd64.

Patch Set 1 #

Patch Set 2 : diff -r 6939fe74ea98 https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r bf9de8d2e308 https://code.google.com/p/go #

Patch Set 4 : diff -r bf9de8d2e308 https://code.google.com/p/go #

Total comments: 6

Patch Set 5 : diff -r 0365e0923a8f https://code.google.com/p/go #

Patch Set 6 : diff -r 0365e0923a8f https://code.google.com/p/go #

Patch Set 7 : diff -r 0365e0923a8f https://code.google.com/p/go #

Patch Set 8 : diff -r 0365e0923a8f https://code.google.com/p/go #

Total comments: 6

Patch Set 9 : diff -r 0365e0923a8f https://code.google.com/p/go #

Patch Set 10 : diff -r 0365e0923a8f https://code.google.com/p/go #

Patch Set 11 : diff -r 0365e0923a8f https://code.google.com/p/go #

Total comments: 4

Patch Set 12 : diff -r 6b0ef65315eb https://code.google.com/p/go #

Patch Set 13 : diff -r 6b0ef65315eb https://code.google.com/p/go #

Patch Set 14 : diff -r 6b0ef65315eb https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M misc/cgo/test/cthread_unix.c View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/cgo/testso/cgoso.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6l/obj.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/lib.c View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/go/build/build.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +17 lines, -15 lines 0 comments Download
M src/pkg/os/user/lookup_unix.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/cgo/cgo.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/cgo/dragonfly.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/cgo/gcc_dragonfly_386.c View 1 2 3 4 5 6 7 8 9 10 11 12 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_dragonfly_amd64.c View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_setenv.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/cgo/setenv.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/run.bash View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 24
varialus
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2013-08-30 05:27:37 UTC) #1
jsing
https://codereview.appspot.com/13247046/diff/3001/src/pkg/go/build/build.go File src/pkg/go/build/build.go (right): https://codereview.appspot.com/13247046/diff/3001/src/pkg/go/build/build.go#newcode263 src/pkg/go/build/build.go:263: "dragonfly/amd64": true, You need to run gofmt on this. ...
10 years, 7 months ago (2013-08-30 15:39:17 UTC) #2
varialus
Hello golang-dev@googlegroups.com, jsing@google.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2013-08-30 16:53:50 UTC) #3
iant
https://codereview.appspot.com/13247046/diff/15001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): https://codereview.appspot.com/13247046/diff/15001/src/cmd/ld/lib.c#newcode565 src/cmd/ld/lib.c:565: #if !defined(__DragonFly__) This is incorrect. It's a host/target confusion--that ...
10 years, 7 months ago (2013-08-30 18:21:54 UTC) #4
varialus
https://codereview.appspot.com/13247046/diff/15001/src/pkg/runtime/cgo/gcc_dragonfly_amd64.c File src/pkg/runtime/cgo/gcc_dragonfly_amd64.c (right): https://codereview.appspot.com/13247046/diff/15001/src/pkg/runtime/cgo/gcc_dragonfly_amd64.c#newcode1 src/pkg/runtime/cgo/gcc_dragonfly_amd64.c:1: // Copyright 2009 The Go Authors. All rights reserved. ...
10 years, 7 months ago (2013-08-30 20:08:48 UTC) #5
varialus
Hello golang-dev@googlegroups.com, jsing@google.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2013-08-30 20:09:07 UTC) #6
varialus
Oops, when I fixed this I accidentally used getgoos() instead of checking the HEADTYPE. Is ...
10 years, 7 months ago (2013-08-30 20:36:38 UTC) #7
varialus
Hello golang-dev@googlegroups.com, jsing@google.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2013-08-30 20:54:39 UTC) #8
varialus
https://codereview.appspot.com/13247046/diff/15001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): https://codereview.appspot.com/13247046/diff/15001/src/cmd/ld/lib.c#newcode565 src/cmd/ld/lib.c:565: #if !defined(__DragonFly__) I updated it to check the HEADTYPE ...
10 years, 7 months ago (2013-08-30 21:01:30 UTC) #9
iant
https://codereview.appspot.com/13247046/diff/35001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): https://codereview.appspot.com/13247046/diff/35001/src/cmd/ld/lib.c#newcode580 src/cmd/ld/lib.c:580: if( !((strcmp(pkg, "net") == 0) || (strcmp(pkg, "os/user") == ...
10 years, 7 months ago (2013-08-30 21:42:28 UTC) #10
varialus
https://codereview.appspot.com/13247046/diff/35001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): https://codereview.appspot.com/13247046/diff/35001/src/cmd/ld/lib.c#newcode580 src/cmd/ld/lib.c:580: if( !((strcmp(pkg, "net") == 0) || (strcmp(pkg, "os/user") == ...
10 years, 7 months ago (2013-08-31 00:01:38 UTC) #11
varialus
Hello golang-dev@googlegroups.com, jsing@google.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2013-08-31 00:03:50 UTC) #12
iant
https://codereview.appspot.com/13247046/diff/45001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): https://codereview.appspot.com/13247046/diff/45001/src/cmd/ld/lib.c#newcode586 src/cmd/ld/lib.c:586: // No cgo check because ldhostobj() not called while ...
10 years, 7 months ago (2013-08-31 16:52:00 UTC) #13
varialus
https://codereview.appspot.com/13247046/diff/45001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): https://codereview.appspot.com/13247046/diff/45001/src/cmd/ld/lib.c#newcode586 src/cmd/ld/lib.c:586: // No cgo check because ldhostobj() not called while ...
10 years, 7 months ago (2013-08-31 20:11:02 UTC) #14
varialus
That last round was soul crushingly depressing. Might have something to do how many fraking ...
10 years, 7 months ago (2013-09-01 00:04:04 UTC) #15
bradfitz
FWIW, you got a shout-out in https://code.google.com/p/go/source/detail?r=fb7526b2f6d838cfab4ebfd2fe107c3aa6cd964b Half the fun of golang-dev is being humbled. ...
10 years, 7 months ago (2013-09-01 17:00:28 UTC) #16
varialus
Thank you pointing that out as I probably wouldn't have run into it otherwise. I ...
10 years, 7 months ago (2013-09-01 22:53:21 UTC) #17
iant
On 2013/09/01 00:04:04, varialus wrote: > That last round was soul crushingly depressing. > > ...
10 years, 6 months ago (2013-09-03 13:34:19 UTC) #18
jsing
On 3 September 2013 23:34, <iant@golang.org> wrote: > On 2013/09/01 00:04:04, varialus wrote: > >> ...
10 years, 6 months ago (2013-09-03 18:57:15 UTC) #19
varialus
On 2013/09/03 18:57:15, jsing wrote: > On 3 September 2013 23:34, <mailto:iant@golang.org> wrote: > > ...
10 years, 6 months ago (2013-09-03 23:51:23 UTC) #20
varialus
Sorry about that last message. I was on my phone and must have accidentally touched ...
10 years, 6 months ago (2013-09-04 00:02:34 UTC) #21
varialus
Hello golang-dev@googlegroups.com, jsing@google.com, iant@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2013-09-04 21:50:42 UTC) #22
iant
LGTM Thanks for your patience on this.
10 years, 6 months ago (2013-09-04 22:17:47 UTC) #23
iant
10 years, 6 months ago (2013-09-04 22:19:25 UTC) #24
*** Submitted as https://code.google.com/p/go/source/detail?r=6828de30a735 ***

cgo: enable cgo on dragonfly

Enable cgo for dragonfly/386 and dragonfly/amd64.

R=golang-dev, jsing, iant, bradfitz
CC=golang-dev
https://codereview.appspot.com/13247046

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b