Inspector shows up after ghost inspector

Inspector shows up after ghost inspector

- Per UX, after ghost inspector finishes, real inspector starts
- Changed new service creation to not bounce the box around
- Made a couple of other small tweaks for sandbox edge cases and capitalization

https://code.launchpad.net/~gary/juju-gui/ghostDeploy/+merge/185933

(do not edit description out of merge proposal)

[gary.poster, 2013-09-16 21:15:57]

Please take a look.

[gary.poster, 2013-09-16 21:22:16]

95% fly-bys.  Sorry.

https://codereview.appspot.com/13246050/diff/1/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/13246050/diff/1/app/store/env/sandbox.js#newco...
app/store/env/sandbox.js:859: return null; // Probably unit/service was deleted.
This was a flyby: when deleting a service then sometimes this would trigger. 
I'll remove if a test is needed; it is just for exploratory testing AFAIK.

https://codereview.appspot.com/13246050/diff/1/app/store/env/sandbox.js#newco...
app/store/env/sandbox.js:868: return null; // Probably unit/service was deleted.
As above.

https://codereview.appspot.com/13246050/diff/1/app/templates/service-constrai...
File app/templates/service-constraints-viewlet.handlebars (right):

https://codereview.appspot.com/13246050/diff/1/app/templates/service-constrai...
app/templates/service-constraints-viewlet.handlebars:3: <h2>Constraints for new
units</h2>
Fly-by.  Every other title is sentence cased.  I prefer title cased, but this is
easier for now, and I'm not sure if this is actually something that UX cares
about.

https://codereview.appspot.com/13246050/diff/1/app/templates/service-relation...
File app/templates/service-relations-viewlet.handlebars (right):

https://codereview.appspot.com/13246050/diff/1/app/templates/service-relation...
app/templates/service-relations-viewlet.handlebars:2: <h2>Relations</h2>
Every other non-intro tab has a header.  It needs one.  Sorry, another fly-by.

https://codereview.appspot.com/13246050/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/13246050/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:306: ghostService.set('localCreation', true);
This line is about...well, see the comment.

https://codereview.appspot.com/13246050/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:307:
this.options.environment.createServiceInspector(ghostService);
This was the only change that this branch actually needed to accomplish the
stated task.  Sorry.

https://codereview.appspot.com/13246050/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13246050/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1391: serviceMenu.one('.destroy-service').hide();
Another fly-by.  We should actually make this menu show and hide with inspector,
but I was amazingly able to hold myself back from implementing that.  (It was
because I couldn't see how to do it quickly :-P).

https://codereview.appspot.com/13246050/diff/1/app/views/viewlets/inspector-h...
File app/views/viewlets/inspector-header.js (right):

https://codereview.appspot.com/13246050/diff/1/app/views/viewlets/inspector-h...
app/views/viewlets/inspector-header.js:35: if (model instanceof
models.BrowserCharm) {
Another flyby.  Jeff pointed out the .scheme conditional, which seemed
unnecessarily obscure to me.  This seems nice and clear to me.

[matthew.scott, 2013-09-16 21:53:32]

LGTM, QA okay in Chrome/Go Env (starting up IE now, will comment if anything
goes wrong)

https://codereview.appspot.com/13246050/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/13246050/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:306: ghostService.set('localCreation', true);
On 2013/09/16 21:22:16, gary.poster wrote:
> This line is about...well, see the comment.

Would like to see this defined in the Service model's ATTRs with a comment and
default to false, just for consistency's sake.

https://codereview.appspot.com/13246050/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13246050/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1099: // box.model.set('localCreation', false);
Remove (assuming flag gets unset later?)

[matthew.scott, 2013-09-16 22:21:49]

IE QA okay - services dragged onto the canvas don't retain drop coordinates, but
that's true in trunk as well.  Will hunt or file bug.

[gary.poster, 2013-09-17 01:06:30]

*** Submitted:

Inspector shows up after ghost inspector

- Per UX, after ghost inspector finishes, real inspector starts
- Changed new service creation to not bounce the box around
- Made a couple of other small tweaks for sandbox edge cases and capitalization

R=matthew.scott
CC=
https://codereview.appspot.com/13246050