Issue 13244043: mailfs: proper support for utf-8 IMAP searches

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13244043: mailfs: proper support for utf-8 IMAP searches

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by akumar

Modified:
11 years, 4 months ago

Reviewers:

CC:
rsc_swtch, d, rsc, 0intro, codebot

Visibility:
Public.

Description

UTF-8 searches with the SEARCH command must be conducted in two steps: the first sends the SEARCH command with the length of the UTF-8 encoded string and the second sends the literal search term. The searches need to not be quoted.

Patch Set 1 #

Patch Set 2 : make second step more general #

Patch Set 3 : fix mem leaks: free sx properly #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -10 lines)			Patch
	M	src/cmd/upas/nfs/imap.c	View	1 2	11 chunks	+45 lines, -10 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

0intro

I've tested it with Plan 9 imap4d and it seems to work fine.

11 years, 4 months ago (2013-08-27 05:58:17 UTC) #4

rsc

11 years, 4 months ago (2013-09-06 20:09:33 UTC) #5

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=faec26111cd6 ***

mailfs: support for UTF-8 searches

UTF-8 searches with the SEARCH command must
be conducted in two steps: the first sends
the SEARCH command with the length of the
UTF-8 encoded string and the second sends
the literal search term. The searches need
to not be quoted.

R=rsc, david.ducolombier, rsc, 0intro
CC=plan9port.codebot
https://codereview.appspot.com/13244043

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages