Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4473)

Issue 13243043: Flip isSP2010 check to isSP2007 to include support for SP2013 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by Tanmay Vartak
Modified:
10 years, 8 months ago
Reviewers:
ejona
CC:
connector-cr_google.com
Visibility:
Public.

Description

Flip isSP2010 check to isSP2007 to include support for SP2013

Patch Set 1 #

Total comments: 4

Patch Set 2 : with code review comments implemented #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java View 1 4 chunks +6 lines, -4 lines 0 comments Download
M src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Tanmay Vartak
10 years, 8 months ago (2013-08-26 21:30:55 UTC) #1
ejona
https://codereview.appspot.com/13243043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (left): https://codereview.appspot.com/13243043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#oldcode422 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:422: // Retrieving list of databases failed, but we can ...
10 years, 8 months ago (2013-08-26 21:41:35 UTC) #2
Tanmay Vartak
10 years, 8 months ago (2013-08-26 22:19:42 UTC) #3
ejona
10 years, 8 months ago (2013-08-26 22:28:14 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b