Changes 'Save' button to 'Cancel'

Changes 'Save' button to 'Cancel'

Because of technical limitations that would push release out
this branch converts the Save button in the ghost inspector
to a Cancel button and then mirrors the same functionality
to the X on the ghost Inspector.

https://code.launchpad.net/~hatch/juju-gui/save-to-cancel/+merge/186397

(do not edit description out of merge proposal)

[jeff.pihach, 2013-09-18 17:31:30]

Please take a look.

[benji, 2013-09-18 18:11:02]

Code and QA are LGTM

https://codereview.appspot.com/13242060/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/13242060/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:187: @method resetCanvas
An @return that spells out the non-returnness of this method would be nice.

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js
File test/test_ghost_inspector.js (right):

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:249: it('It resets the canvas when hitting cancel',
function(done) {
s/It //

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:270: assert.equal(serviceIcon.get('textContent'),
'(mediawiki)', 'icon after');
Nice comments and use of assert messages.

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:279: it('It resets the canvas when hitting X',
function(done) {
s/It /

[jeff.pihach, 2013-09-18 19:00:38]

Thank you for the review and QA!

https://codereview.appspot.com/13242060/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/13242060/diff/1/app/views/ghost-inspector.js#n...
app/views/ghost-inspector.js:187: @method resetCanvas
On 2013/09/18 18:11:02, benji wrote:
> An @return that spells out the non-returnness of this method would be nice.

Done.

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js
File test/test_ghost_inspector.js (right):

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:249: it('It resets the canvas when hitting cancel',
function(done) {
On 2013/09/18 18:11:02, benji wrote:
> s/It //

Done.

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:270: assert.equal(serviceIcon.get('textContent'),
'(mediawiki)', 'icon after');
Thanks!

https://codereview.appspot.com/13242060/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:279: it('It resets the canvas when hitting X',
function(done) {
On 2013/09/18 18:11:02, benji wrote:
> s/It /

Done.

[jeff.pihach, 2013-09-18 19:08:53]

*** Submitted:

Changes 'Save' button to 'Cancel'

Because of technical limitations that would push release out
this branch converts the Save button in the ghost inspector
to a Cancel button and then mirrors the same functionality
to the X on the ghost Inspector.

R=benji
CC=
https://codereview.appspot.com/13242060