Issue 13242054: code review 13242054: go.text/encoding/traditionalchinese: new package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13242054: code review 13242054: go.text/encoding/traditionalchinese: new package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by nigeltao

Modified:
11 years, 11 months ago

Reviewers:
r

CC:
r, andybalholm, golang-dev, mpvl, rog

Visibility:
Public.

Description

go.text/encoding/traditionalchinese: new package.

Patch Set 2 : diff -r d6e5155a7723 https://code.google.com/p/go.text #

Patch Set 3 : diff -r d6e5155a7723 https://code.google.com/p/go.text #

Patch Set 4 : diff -r d6e5155a7723 https://code.google.com/p/go.text #

Total comments: 1

Patch Set 5 : diff -r d6e5155a7723 https://code.google.com/p/go.text #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37735 lines, -9 lines)			Patch
M	encoding/encoding_test.go	View	1 2 3 4	7 chunks	+51 lines, -9 lines	0 comments	Download
A	encoding/testdata/sunzi-bingfa-traditional-big5.txt	View	1 2 3 4	1 chunk	+106 lines, -0 lines	0 comments	Download
A	encoding/testdata/sunzi-bingfa-traditional-utf-8.txt	View	1 2 3 4	1 chunk	+106 lines, -0 lines	0 comments	Download
A	encoding/traditionalchinese/big5.go	View	1 2 3 4	1 chunk	+193 lines, -0 lines	0 comments	Download
A	encoding/traditionalchinese/maketables.go	View	1 2 3 4	1 chunk	+139 lines, -0 lines	0 comments	Download
A	encoding/traditionalchinese/tables.go	View	1 2	1 chunk	+37140 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: andybalholm@gmail.com, golang-dev@googlegroups.com, mpvl@golang.org, rogpeppe@gmail.com), I'd like you to review this change to ...

11 years, 11 months ago (2013-09-11 05:06:40 UTC) #1

nigeltao

The data tables could certainly be smaller, but what's there now is relatively simple. We ...

11 years, 11 months ago (2013-09-11 05:07:37 UTC) #2

LGTM https://codereview.appspot.com/13242054/diff/9001/encoding/traditionalchinese/big5.go File encoding/traditionalchinese/big5.go (right): https://codereview.appspot.com/13242054/diff/9001/encoding/traditionalchinese/big5.go#newcode137 encoding/traditionalchinese/big5.go:137: if big5Encode0Low <= r && r < big5Encode0High ...

11 years, 11 months ago (2013-09-11 05:09:20 UTC) #3

nigeltao

11 years, 11 months ago (2013-09-11 05:32:56 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=82c1364fdbc0&repo=text ***

go.text/encoding/traditionalchinese: new package.

R=r
CC=andybalholm, golang-dev, mpvl, rogpeppe
https://codereview.appspot.com/13242054

Expand All Messages | Collapse All Messages