Fixes state issues with browser/service view

Fixes state issues with browser/service view

- Fixes #1217449 & #1217450
- viewmode controls widget now clear the events to the DOM it binds with a
custom destroy event helper.
- Since it's not cleaning them up, we can not clean them in tests manually.
- Update the app.js triggers on the viewmode control events to build the
entire url and send that along to the navigate call.
- Make sure we destroy controls when we're done with the app managing them
(while the gui service views are available)
- The initState needs to clear old views so that when we re-init no old views
are holding events that no longer apply. Share the code now since it's used in
multiple places.
- _getStateUrl was improperly updating the _oldState to aid testing. Remove
that and fix tests.
- In some cases when hidden, we might have no subapp._sidebar but the
_oldState says there's been no state change.
- Update tests around initState, viewmode controls widget, etc.

https://code.launchpad.net/~rharding/juju-gui/more-state-issues/+merge/182459

(do not edit description out of merge proposal)

[rharding, 2013-08-27 19:31:33]

Please take a look.

[rharding, 2013-08-28 00:35:41]

Please take a look.

[rharding, 2013-08-28 00:46:57]

Please take a look.

[rharding, 2013-08-28 00:47:58]

QA Notes: see the bugs for what *should* work now that did not previously.

[jeff.pihach, 2013-08-28 04:51:21]

There is a console log in sandbox.js:788 if you could remove that plz that would
be awesome!

LGTM QA OK
IE QA OK

Thanks for getting this finished - looks like it was the last bug fix!

[rharding, 2013-08-28 11:21:45]

On 2013/08/28 04:51:21, jeff.pihach wrote:
> There is a console log in sandbox.js:788 if you could remove that plz that
would
> be awesome!

Sure thing, removed from the tree, didn't resubmit it.

[frankban, 2013-08-28 11:53:03]

LGTM, with just a question below.
Thank you Rick.

https://codereview.appspot.com/13242046/diff/7001/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/13242046/diff/7001/app/subapps/browser/browser...
app/subapps/browser/browser.js:662: var forceFullscreen = false;
Isn't this writable as "var forceFullscreen = !this._fullscreen;"?
The same for "sidebar" below.

https://codereview.appspot.com/13242046/diff/7001/app/widgets/viewmode-contro...
File app/widgets/viewmode-controls.js (right):

https://codereview.appspot.com/13242046/diff/7001/app/widgets/viewmode-contro...
app/widgets/viewmode-controls.js:227: // Including this event.
Nice.

[rharding, 2013-08-28 12:01:45]

Thanks for the reviews!

https://codereview.appspot.com/13242046/diff/7001/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/13242046/diff/7001/app/subapps/browser/browser...
app/subapps/browser/browser.js:662: var forceFullscreen = false;
On 2013/08/28 11:53:03, frankban wrote:
> Isn't this writable as "var forceFullscreen = !this._fullscreen;"?
> The same for "sidebar" below.

Yes, it is at this point, however we then set this._sidebar below. The trouble
is that we need to 'remember' that we had to force this to get editorial content
to load farther down. 

It was done like this in fullscreen to keep the idea/etc consistent between the
two functions.

[rharding, 2013-08-28 12:10:12]

*** Submitted:

Fixes state issues with browser/service view

- Fixes #1217449 & #1217450
- viewmode controls widget now clear the events to the DOM it binds with a
custom destroy event helper.
- Since it's not cleaning them up, we can not clean them in tests manually.
- Update the app.js triggers on the viewmode control events to build the
entire url and send that along to the navigate call.
- Make sure we destroy controls when we're done with the app managing them
(while the gui service views are available)
- The initState needs to clear old views so that when we re-init no old views
are holding events that no longer apply. Share the code now since it's used in
multiple places.
- _getStateUrl was improperly updating the _oldState to aid testing. Remove
that and fix tests.
- In some cases when hidden, we might have no subapp._sidebar but the
_oldState says there's been no state change.
- Update tests around initState, viewmode controls widget, etc.

R=jeff.pihach, frankban
CC=
https://codereview.appspot.com/13242046