Issue 13241053: Make bootstrap work from a windows client.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13241053: Make bootstrap work from a windows client.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by thumper

Modified:
10 years, 8 months ago

Reviewers:
mp+186225, dave

Visibility:
Public.

Description

Make bootstrap work from a windows client. This change uses path rather than filepath for the Join methods for the cloudinit and upstart job creation. This is because the client OS may be windows, but the code is running on linux server-side. A util function has been added that should be used in the agent and worker code to ease the transition to supporting windows as a server OS. The generated cloudinit content for new machines is logged out at TRACE level to provide debugging info. This is already on the lp:juju-core/1.14 branch. https://code.launchpad.net/~thumper/juju-core/fix-windows-build/+merge/186225 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -10 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	scripts/win-installer/setup.iss	View	1 chunk	+1 line, -1 line	0 comments	Download
M	upstart/service.go	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	utils/file.go	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dave_cheney.net

10 years, 8 months ago (2013-09-18 01:41:26 UTC) #2

On 2013/09/18 01:31:13, thumper wrote:
> Please take a look.

LGTM. This is icky.

Expand All Messages | Collapse All Messages