User subscription settings with item name appended to the itemid subscriptions

Now the subscriptions looks like this:
itemid:7bcf8764a2ce4e7e80f18458fcea1b18 (Home)

If the item will be renamed, than the new name will appear.

If item was deleted or completely destroyed, then it will display 
itemid:7bcf8764a2ce4e7e80f18458fcea1b18 (This item doesn't exist)

[Thomas.J.Waldmann, 2013-09-09 11:37:56]

https://codereview.appspot.com/13240047/diff/1/MoinMoin/forms.py
File MoinMoin/forms.py (right):

https://codereview.appspot.com/13240047/diff/1/MoinMoin/forms.py#newcode161
MoinMoin/forms.py:161: appends to the end of ITEMID subscriptions the name of
the item for clarity.
appends <what's appended> to <what it gets appended to>

https://codereview.appspot.com/13240047/diff/1/MoinMoin/forms.py#newcode180
MoinMoin/forms.py:180: with flaskg.storage.indexer.ix[LATEST_REVS].searcher() as
searcher:
why don't you call flaskg.storage.documents() ?

maybe this could also share some code with subscription processing - there, you
also have all these subscriptions and need to find out the items they point to.

https://codereview.appspot.com/13240047/diff/1/MoinMoin/forms.py#newcode185
MoinMoin/forms.py:185: name0 = "This item doesn't exist"
depending on the type of item you get back from search, there might be already
such an attribute.

https://codereview.appspot.com/13240047/diff/1/MoinMoin/forms.py#newcode190
MoinMoin/forms.py:190: return self.separator.join(subscriptions)
in general, i am not sure whether this patching around is the best way to solve
this problem. maybe ask jek (from flatland project).

[ana.balica, 2013-09-10 21:53:00]

https://codereview.appspot.com/13240047/diff/1/MoinMoin/forms.py
File MoinMoin/forms.py (right):

https://codereview.appspot.com/13240047/diff/1/MoinMoin/forms.py#newcode190
MoinMoin/forms.py:190: return self.separator.join(subscriptions)
On 2013/09/09 11:37:56, Thomas.J.Waldmann wrote:
> in general, i am not sure whether this patching around is the best way to
solve
> this problem. maybe ask jek (from flatland project).

So there are some other ways to solve the problem, but they lead to some extra
complex stuff too. For instance, we can use
List.of(String.using(default_factory=better_subscriptions) where
better_subscriptions is a function that will append the names (same thing as u()
does). But we need to strip this afterwards, in validator for example (here we
do it in value()). Also we need to rewrite the printing (a List outputs a raw
list), but for that we can easily use MyJoinedString instead of List.

Generally it might be a good practice to use a compound and subclass it if it
fits our needs. 

Moreover we will probably change this settings appearance after the UI changes.