Issue 13239050: Refactor getting and rendering of html diff

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13239050: Refactor getting and rendering of html diff (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by ana.balica

Modified:
10 years, 8 months ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Split the getting of an html diff and the rendering of a template that uses html diff. Also make html and text diff functions imports global to the file.

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -10 lines)			Patch
	M	MoinMoin/items/_tests/test_Content.py	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	MoinMoin/items/content.py	View		4 chunks	+26 lines, -10 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

10 years, 8 months ago (2013-09-09 11:21:55 UTC) #1

https://codereview.appspot.com/13239050/diff/1/MoinMoin/items/content.py
File MoinMoin/items/content.py (right):

https://codereview.appspot.com/13239050/diff/1/MoinMoin/items/content.py#newc...
MoinMoin/items/content.py:879: return [(d[0], Markup(d[1]), d[2], Markup(d[3]))
for d in html_diff(old_text, new_text)]
well, not quite same return type than the text stuff, but i guess it can't get
better than that and still be flexible enough.

Expand All Messages | Collapse All Messages